Skip to content

Commit ecca191

Browse files
alex-courtisalex-courtis
committed
feat(#2415): granular highlight_git, normalise git groups (#2487)
* docs: update CONTRIBUTING.md (#2485) * feat(#2415): granular highlight_git, normalise git groups
1 parent e77407f commit ecca191

File tree

8 files changed

+189
-140
lines changed

8 files changed

+189
-140
lines changed

‎doc/nvim-tree-lua.txt‎

Lines changed: 57 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ Following is the default configuration. See |nvim-tree-opts| for details.
386386
indent_width = 2,
387387
special_files = { "Cargo.toml", "Makefile", "README.md", "readme.md" },
388388
symlink_destination = true,
389-
highlight_git = false,
389+
highlight_git = "none",
390390
highlight_diagnostics = "none",
391391
highlight_opened_files = "none",
392392
highlight_modified = "none",
@@ -830,12 +830,13 @@ Whether to show the destination of the symlink.
830830
Type: `boolean`, Default: `true`
831831

832832
*nvim-tree.renderer.highlight_git*
833-
Enable highlight for git attributes using `NvimTreeGit*` highlight groups.
833+
Enable highlight for git attributes using `NvimTreeGit*HL` highlight groups.
834834
Requires |nvim-tree.git.enable|
835-
Type: `boolean`, Default: `false`
835+
Value can be `"none"`, `"icon"`, `"name"` or `"all"`.
836+
Type: `string`, Default: `"none"`
836837

837838
*nvim-tree.renderer.highlight_diagnostics*
838-
Enable highlight for diagnostics using `NvimTreeDiagnostic*HL` highlight groups.
839+
Enable highlight for diagnostics using `NvimTreeDiagnostic*HL` highlight groups.
839840
Requires |nvim-tree.diagnostics.enable|
840841
Value can be `"none"`, `"icon"`, `"name"` or `"all"`.
841842
Type: `string`, Default: `"none"`
@@ -2234,7 +2235,7 @@ Folder Text: >
22342235
NvimTreeSymlinkFolderName Directory
22352236
<
22362237
Icon: >
2237-
NvimTreeFolderIcon "guifg=#8094b4 ctermfg=Blue"
2238+
NvimTreeFolderIcon guifg=#8094b4 ctermfg=Blue
22382239
NvimTreeFileIcon NvimTreeNormal
22392240
NvimTreeSymlinkIcon NvimTreeNormal
22402241
NvimTreeOpenedFileIcon NvimTreeOpenedFile
@@ -2257,38 +2258,38 @@ Bookmark Highlight: >
22572258
NvimTreeBookmarkHL SpellLocal
22582259
<
22592260
Picker: >
2260-
NvimTreeWindowPicker "guifg=#ededed guibg=#4493c8 gui=bold ctermfg=White ctermbg=Cyan"
2261+
NvimTreeWindowPicker guifg=#ededed guibg=#4493c8 gui=bold ctermfg=White ctermbg=Cyan
22612262
<
22622263
Live Filter: >
22632264
NvimTreeLiveFilterPrefix PreProc
22642265
NvimTreeLiveFilterValue ModeMsg
22652266
<
22662267
Git Icon: >
2267-
NvimTreeGitDeleted Statement
2268-
NvimTreeGitDirty Statement
2269-
NvimTreeGitIgnored Comment
2270-
NvimTreeGitMerge Constant
2271-
NvimTreeGitNew PreProc
2272-
NvimTreeGitRenamed PreProc
2273-
NvimTreeGitStaged Constant
2268+
NvimTreeGitDeletedIcon Statement
2269+
NvimTreeGitDirtyIcon Statement
2270+
NvimTreeGitIgnoredIcon Comment
2271+
NvimTreeGitMergeIcon Constant
2272+
NvimTreeGitNewIcon PreProc
2273+
NvimTreeGitRenamedIcon PreProc
2274+
NvimTreeGitStagedIcon Constant
22742275
<
22752276
Git File Text: >
2276-
NvimTreeFileDirty NvimTreeGitDirty
2277-
NvimTreeFileStaged NvimTreeGitStaged
2278-
NvimTreeFileMerge NvimTreeGitMerge
2279-
NvimTreeFileRenamed NvimTreeGitRenamed
2280-
NvimTreeFileNew NvimTreeGitNew
2281-
NvimTreeFileDeleted NvimTreeGitDeleted
2282-
NvimTreeFileIgnored NvimTreeGitIgnored
2277+
NvimTreeGitFileDeletedHL NvimTreeGitDeletedIcon
2278+
NvimTreeGitFileDirtyHL NvimTreeGitDirtyIcon
2279+
NvimTreeGitFileIgnoredHL NvimTreeGitIgnoredIcon
2280+
NvimTreeGitFileMergeHL NvimTreeGitMergeIcon
2281+
NvimTreeGitFileNewHL NvimTreeGitNewIcon
2282+
NvimTreeGitFileRenamedHL NvimTreeGitRenamedIcon
2283+
NvimTreeGitFileStagedHL NvimTreeGitStagedIcon
22832284
<
22842285
Git Folder Text: >
2285-
NvimTreeFolderDirty NvimTreeFileDirty
2286-
NvimTreeFolderStaged NvimTreeFileStaged
2287-
NvimTreeFolderMerge NvimTreeFileMerge
2288-
NvimTreeFolderRenamed NvimTreeFileRenamed
2289-
NvimTreeFolderNew NvimTreeFileNew
2290-
NvimTreeFolderDeleted NvimTreeFileDeleted
2291-
NvimTreeFolderIgnored NvimTreeFileIgnored
2286+
NvimTreeGitFolderDeletedHL NvimTreeGitFileDeletedHL
2287+
NvimTreeGitFolderDirtyHL NvimTreeGitFileDirtyHL
2288+
NvimTreeGitFolderIgnoredHL NvimTreeGitFileIgnoredHL
2289+
NvimTreeGitFolderMergeHL NvimTreeGitFileMergeHL
2290+
NvimTreeGitFolderNewHL NvimTreeGitFileNewHL
2291+
NvimTreeGitFolderRenamedHL NvimTreeGitFileRenamedHL
2292+
NvimTreeGitFolderStagedHL NvimTreeGitFileStagedHL
22922293
<
22932294
Diagnostics Icon: >
22942295
NvimTreeDiagnosticErrorIcon DiagnosticError
@@ -2303,12 +2304,11 @@ Diagnostics File Highlight: >
23032304
NvimTreeDiagnosticHintFileHL DiagnosticUnderlineHint
23042305
<
23052306
Diagnostics Folder Highlight: >
2306-
NvimTreeDiagnosticErrorFolderHL DiagnosticUnderlineError
2307-
NvimTreeDiagnosticWarnFolderHL DiagnosticUnderlineWarn
2308-
NvimTreeDiagnosticInfoFolderHL DiagnosticUnderlineInfo
2309-
NvimTreeDiagnosticHintFolderHL DiagnosticUnderlineHint
2307+
NvimTreeDiagnosticErrorFolderHL NvimTreeDiagnosticErrorFileHL
2308+
NvimTreeDiagnosticWarnFolderHL NvimTreeDiagnosticWarnFileHL
2309+
NvimTreeDiagnosticInfoFolderHL NvimTreeDiagnosticInfoFileHL
2310+
NvimTreeDiagnosticHintFolderHL NvimTreeDiagnosticHintFileHL
23102311
<
2311-
23122312
==============================================================================
23132313
8.1 HIGHLIGHT OVERHAUL *nvim-tree-highlight-overhaul*
23142314

@@ -2324,7 +2324,7 @@ Diagnostics Folder Highlight: >
23242324
- `highlight_xxx` is additive instead of overwriting. See
23252325
|nvim-tree-opts-renderer| for precedence.
23262326

2327-
Legacy style may be applied: >
2327+
Legacy diagnostic HL style may be applied: >
23282328
23292329
:hi link NvimTreeDiagnosticErrorFileHL DiagnosticError
23302330
:hi link NvimTreeDiagnosticWarnFileHL DiagnosticWarn
@@ -2339,6 +2339,30 @@ Legacy style may be applied: >
23392339
Legacy highlight group are still obeyed when they are defined and the current
23402340
highlight group is not, hard linking as follows: >
23412341
2342+
NvimTreeGitDeletedIcon NvimTreeGitDeleted
2343+
NvimTreeGitDirtyIcon NvimTreeGitDirty
2344+
NvimTreeGitIgnoredIcon NvimTreeGitIgnored
2345+
NvimTreeGitMergeIcon NvimTreeGitMerge
2346+
NvimTreeGitNewIcon NvimTreeGitNew
2347+
NvimTreeGitRenamedIcon NvimTreeGitRenamed
2348+
NvimTreeGitStagedIcon NvimTreeGitStaged
2349+
2350+
NvimTreeGitFileDeletedHL NvimTreeFileDeleted
2351+
NvimTreeGitFileDirtyHL NvimTreeFileDirty
2352+
NvimTreeGitFileIgnoredHL NvimTreeFileIgnored
2353+
NvimTreeGitFileMergeHL NvimTreeFileMerge
2354+
NvimTreeGitFileNewHL NvimTreeFileNew
2355+
NvimTreeGitFileRenamedHL NvimTreeFileRenamed
2356+
NvimTreeGitFileStagedHL NvimTreeFileStaged
2357+
2358+
NvimTreeGitFolderDeletedHL NvimTreeFolderDeleted
2359+
NvimTreeGitFolderDirtyHL NvimTreeFolderDirty
2360+
NvimTreeGitFolderIgnoredHL NvimTreeFolderIgnored
2361+
NvimTreeGitFolderMergeHL NvimTreeFolderMerge
2362+
NvimTreeGitFolderNewHL NvimTreeFolderNew
2363+
NvimTreeGitFolderRenamedHL NvimTreeFolderRenamed
2364+
NvimTreeGitFolderStagedHL NvimTreeFolderStaged
2365+
23422366
NvimTreeLspDiagnosticsError NvimTreeDiagnosticErrorIcon
23432367
NvimTreeLspDiagnosticsWarning NvimTreeDiagnosticWarnIcon
23442368
NvimTreeLspDiagnosticsInformation NvimTreeDiagnosticInfoIcon

‎lua/nvim-tree.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ local DEFAULT_OPTS = { -- BEGIN_DEFAULT_OPTS
389389
indent_width = 2,
390390
special_files = { "Cargo.toml", "Makefile", "README.md", "readme.md" },
391391
symlink_destination = true,
392-
highlight_git = false,
392+
highlight_git = "none",
393393
highlight_diagnostics = "none",
394394
highlight_opened_files = "none",
395395
highlight_modified = "none",

‎lua/nvim-tree/colors.lua‎

Lines changed: 51 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -70,31 +70,31 @@ local DEFAULT_LINKS = {
7070
NvimTreeLiveFilterValue = "ModeMsg",
7171

7272
-- Git Icon
73-
NvimTreeGitDeleted = "Statement",
74-
NvimTreeGitDirty = "Statement",
75-
NvimTreeGitIgnored = "Comment",
76-
NvimTreeGitMerge = "Constant",
77-
NvimTreeGitNew = "PreProc",
78-
NvimTreeGitRenamed = "PreProc",
79-
NvimTreeGitStaged = "Constant",
73+
NvimTreeGitDeletedIcon = "Statement",
74+
NvimTreeGitDirtyIcon = "Statement",
75+
NvimTreeGitIgnoredIcon = "Comment",
76+
NvimTreeGitMergeIcon = "Constant",
77+
NvimTreeGitNewIcon = "PreProc",
78+
NvimTreeGitRenamedIcon = "PreProc",
79+
NvimTreeGitStagedIcon = "Constant",
8080

8181
-- Git File Text
82-
NvimTreeFileDirty = "NvimTreeGitDirty",
83-
NvimTreeFileStaged = "NvimTreeGitStaged",
84-
NvimTreeFileMerge = "NvimTreeGitMerge",
85-
NvimTreeFileRenamed = "NvimTreeGitRenamed",
86-
NvimTreeFileNew = "NvimTreeGitNew",
87-
NvimTreeFileDeleted = "NvimTreeGitDeleted",
88-
NvimTreeFileIgnored = "NvimTreeGitIgnored",
82+
NvimTreeGitFileDeletedHL = "NvimTreeGitDeletedIcon",
83+
NvimTreeGitFileDirtyHL = "NvimTreeGitDirtyIcon",
84+
NvimTreeGitFileIgnoredHL = "NvimTreeGitIgnoredIcon",
85+
NvimTreeGitFileMergeHL = "NvimTreeGitMergeIcon",
86+
NvimTreeGitFileNewHL = "NvimTreeGitNewIcon",
87+
NvimTreeGitFileRenamedHL = "NvimTreeGitRenamedIcon",
88+
NvimTreeGitFileStagedHL = "NvimTreeGitStagedIcon",
8989

9090
-- Git Folder Text
91-
NvimTreeFolderDirty = "NvimTreeFileDirty",
92-
NvimTreeFolderStaged = "NvimTreeFileStaged",
93-
NvimTreeFolderMerge = "NvimTreeFileMerge",
94-
NvimTreeFolderRenamed = "NvimTreeFileRenamed",
95-
NvimTreeFolderNew = "NvimTreeFileNew",
96-
NvimTreeFolderDeleted = "NvimTreeFileDeleted",
97-
NvimTreeFolderIgnored = "NvimTreeFileIgnored",
91+
NvimTreeGitFolderDeletedHL = "NvimTreeGitFileDeletedHL",
92+
NvimTreeGitFolderDirtyHL = "NvimTreeGitFileDirtyHL",
93+
NvimTreeGitFolderIgnoredHL = "NvimTreeGitFileIgnoredHL",
94+
NvimTreeGitFolderMergeHL = "NvimTreeGitFileMergeHL",
95+
NvimTreeGitFolderNewHL = "NvimTreeGitFileNewHL",
96+
NvimTreeGitFolderRenamedHL = "NvimTreeGitFileRenamedHL",
97+
NvimTreeGitFolderStagedHL = "NvimTreeGitFileStagedHL",
9898

9999
-- Diagnostics Icon
100100
NvimTreeDiagnosticErrorIcon = "DiagnosticError",
@@ -109,22 +109,48 @@ local DEFAULT_LINKS = {
109109
NvimTreeDiagnosticHintFileHL = "DiagnosticUnderlineHint",
110110

111111
-- Diagnostics Folder Highlight
112-
NvimTreeDiagnosticErrorFolderHL = "DiagnosticUnderlineError",
113-
NvimTreeDiagnosticWarnFolderHL = "DiagnosticUnderlineWarn",
114-
NvimTreeDiagnosticInfoFolderHL = "DiagnosticUnderlineInfo",
115-
NvimTreeDiagnosticHintFolderHL = "DiagnosticUnderlineHint",
112+
NvimTreeDiagnosticErrorFolderHL = "NvimTreeDiagnosticErrorFileHL",
113+
NvimTreeDiagnosticWarnFolderHL = "NvimTreeDiagnosticWarnFileHL",
114+
NvimTreeDiagnosticInfoFolderHL = "NvimTreeDiagnosticInfoFileHL",
115+
NvimTreeDiagnosticHintFolderHL = "NvimTreeDiagnosticHintFileHL",
116116
}
117117

118118
-- nvim-tree highlight groups to legacy
119119
local LEGACY_LINKS = {
120+
NvimTreeGitDeletedIcon = "NvimTreeGitDeleted",
121+
NvimTreeGitDirtyIcon = "NvimTreeGitDirty",
122+
NvimTreeGitIgnoredIcon = "NvimTreeGitIgnored",
123+
NvimTreeGitMergeIcon = "NvimTreeGitMerge",
124+
NvimTreeGitNewIcon = "NvimTreeGitNew",
125+
NvimTreeGitRenamedIcon = "NvimTreeGitRenamed",
126+
NvimTreeGitStagedIcon = "NvimTreeGitStaged",
127+
128+
NvimTreeGitFileDeletedHL = "NvimTreeFileDeleted",
129+
NvimTreeGitFileDirtyHL = "NvimTreeFileDirty",
130+
NvimTreeGitFileIgnoredHL = "NvimTreeFileIgnored",
131+
NvimTreeGitFileMergeHL = "NvimTreeFileMerge",
132+
NvimTreeGitFileNewHL = "NvimTreeFileNew",
133+
NvimTreeGitFileRenamedHL = "NvimTreeFileRenamed",
134+
NvimTreeGitFileStagedHL = "NvimTreeFileStaged",
135+
136+
NvimTreeGitFolderDeletedHL = "NvimTreeFolderDeleted",
137+
NvimTreeGitFolderDirtyHL = "NvimTreeFolderDirty",
138+
NvimTreeGitFolderIgnoredHL = "NvimTreeFolderIgnored",
139+
NvimTreeGitFolderMergeHL = "NvimTreeFolderMerge",
140+
NvimTreeGitFolderNewHL = "NvimTreeFolderNew",
141+
NvimTreeGitFolderRenamedHL = "NvimTreeFolderRenamed",
142+
NvimTreeGitFolderStagedHL = "NvimTreeFolderStaged",
143+
120144
NvimTreeDiagnosticErrorIcon = "NvimTreeLspDiagnosticsError",
121145
NvimTreeDiagnosticWarnIcon = "NvimTreeLspDiagnosticsWarning",
122146
NvimTreeDiagnosticInfoIcon = "NvimTreeLspDiagnosticsInformation",
123147
NvimTreeDiagnosticHintIcon = "NvimTreeLspDiagnosticsHint",
148+
124149
NvimTreeDiagnosticErrorFileHL = "NvimTreeLspDiagnosticsErrorText",
125150
NvimTreeDiagnosticWarnFileHL = "NvimTreeLspDiagnosticsWarningText",
126151
NvimTreeDiagnosticInfoFileHL = "NvimTreeLspDiagnosticsInformationText",
127152
NvimTreeDiagnosticHintFileHL = "NvimTreeLspDiagnosticsHintText",
153+
128154
NvimTreeDiagnosticErrorFolderHL = "NvimTreeLspDiagnosticsErrorFolderText",
129155
NvimTreeDiagnosticWarnFolderHL = "NvimTreeLspDiagnosticsWarningFolderText",
130156
NvimTreeDiagnosticInfoFolderHL = "NvimTreeLspDiagnosticsInformationFolderText",

‎lua/nvim-tree/legacy.lua‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,12 @@ local function refactored(opts)
4444

4545
-- 2023/10/08
4646
if type(opts.renderer) == "table" and type(opts.renderer.highlight_diagnostics) == "boolean" then
47-
if opts.renderer.highlight_diagnostics then
48-
opts.renderer.highlight_diagnostics = "name"
49-
else
50-
opts.renderer.highlight_diagnostics = "none"
51-
end
47+
opts.renderer.highlight_diagnostics = opts.renderer.highlight_diagnostics and "name" or "none"
48+
end
49+
50+
-- 2023/10/21
51+
if type(opts.renderer) == "table" and type(opts.renderer.highlight_git) == "boolean" then
52+
opts.renderer.highlight_git = opts.renderer.highlight_git and "name" or "none"
5253
end
5354
end
5455

‎lua/nvim-tree/renderer/builder.lua‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -303,12 +303,6 @@ end
303303
function Builder:_get_highlight_override(node, unloaded_bufnr)
304304
local name_hl, icon_hl
305305

306-
-- git
307-
local git_highlight = git.get_highlight(node)
308-
if git_highlight then
309-
name_hl = git_highlight
310-
end
311-
312306
-- opened file
313307
if self.highlight_opened_files and vim.fn.bufloaded(node.absolute_path) > 0 and vim.fn.bufnr(node.absolute_path) ~= unloaded_bufnr then
314308
if self.highlight_opened_files == "all" or self.highlight_opened_files == "name" then
@@ -445,6 +439,7 @@ function Builder:_build_line(node, idx, num_children, unloaded_bufnr)
445439
end
446440

447441
-- extra highighting
442+
self:_append_highlight(node, git.get_highlight, icon.hl, name.hl)
448443
self:_append_highlight(node, bookmarks.get_highlight, icon.hl, name.hl)
449444
self:_append_highlight(node, diagnostics.get_highlight, icon.hl, name.hl)
450445
self:_append_highlight(node, copy_paste.get_highlight, icon.hl, name.hl)

‎lua/nvim-tree/renderer/components/bookmarks.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ local M = {
77
hl_pos = HL_POSITION.none,
88
}
99

10-
---Bookmark highlight group and position when highlight_bookmark.
10+
---Bookmark highlight group and position when highlight_bookmark
1111
---@param node table
1212
---@return HL_POSITION position none when clipboard empty
1313
---@return string|nil group only when node present in clipboard

‎lua/nvim-tree/renderer/components/diagnostics.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ local M = {
1212
HL_POS = HL_POSITION.none,
1313
}
1414

15-
---Diagnostics text highlight group when highlight_diagnostics.
15+
---Diagnostics highlight group and position when highlight_diagnostics.
1616
---@param node table
1717
---@return HL_POSITION position none when no status
1818
---@return string|nil group only when status

0 commit comments

Comments
 (0)