Skip to content

Conversation

@jason-curtis
Copy link

Previously, apt uninstall would correct to apt install but this is more of the desired behavior

I considered putting this in a separate rule, apt_uninstall, with a higher priority than apt_invalid_operation but this seemed like a more straightforward approach. If there's a preference for doing it that way I can do that instead.

@ik1ne
Copy link
Contributor

ik1ne commented Sep 17, 2019

Running flake8 (PROJECT_DIR)/thefuck/rules gives following error:

thefuck/rules/apt_invalid_operation.py:4:1: F401 'thefuck.utils.replace_argument' imported but unused

I think removing that import will make PR pass the CI build.

@jason-curtis
Copy link
Author

oops, didn't see that this had failed. fixed!

@nvbn
Copy link
Owner

nvbn commented Sep 17, 2019

Looks good, thanks!

@nvbn nvbn merged commit 3bbd0e9 into nvbn:master Sep 17, 2019
@nevercast
Copy link

Just the feature I was looking for, time to update my local thefuck copy! Thanks @thatneat

riley-martine pushed a commit to riley-martine/thefuck that referenced this pull request Dec 7, 2023
* Correct "apt uninstall" -> "apt remove"

* remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants