Fix settings dialog title for 2 base-only panels #19342
Draft
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Discussed in #19301 (comment)
Summary of the issue:
The settings dialog indicate the current profile when "AI image description" and "Math" categories are selected. Though, their config is only global, i.e. not profile dependant.
Description of user facing changes:
When categories "AI Image Description" and "Math" are selected, the settings dialog will indicate "normal configuration", no matter the current active profile since their config is only global. I.e. same as categories "General", "Add-on Store", "Remote Access" or "Privacy and security".
Description of developer facing changes:
None
Description of development approach:
Check for instance of the 2 newly added panels in
NVDASettingsDialog._doOnCategoryChangeTesting strategy:
Manual test
Known issues with pull request:
Some may want these feature to be profile dependant. This may be discussed in new issues or PR; for now these features have been developed without profile support and this PR just makes the GUI consistent with it.
Code Review Checklist: