Skip to content

Conversation

@CyrilleB79
Copy link
Contributor

Link to issue number:

Discussed in #19301 (comment)

Summary of the issue:

The settings dialog indicate the current profile when "AI image description" and "Math" categories are selected. Though, their config is only global, i.e. not profile dependant.

Description of user facing changes:

When categories "AI Image Description" and "Math" are selected, the settings dialog will indicate "normal configuration", no matter the current active profile since their config is only global. I.e. same as categories "General", "Add-on Store", "Remote Access" or "Privacy and security".

Description of developer facing changes:

None

Description of development approach:

Check for instance of the 2 newly added panels in
NVDASettingsDialog._doOnCategoryChange

Testing strategy:

Manual test

Known issues with pull request:

Some may want these feature to be profile dependant. This may be discussed in new issues or PR; for now these features have been developed without profile support and this PR just makes the GUI consistent with it.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant