(2.14) Fast batch: initial fast ingest support #7412
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Member
Author
|
The individual commits could be squashed down prior to merge. Have left them separate for now to ease reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for fast batch publish, currently being designed in ADR-50. An update to the ADR is proposed here to include details contained in this PR: nats-io/nats-architecture-and-design#387.
Most requirements are already included:
AllowBatchPublishto theStreamConfigat API level 3Nats-Fast-Batch-IdNats-Batch-Gap: fail/okNats-Flow(only ack per N messages)Nats-Batch-Commit: 1/eobPubAckat the end, and use the flow control message throughout.This should be sufficient for now to benchmark fast ingest, but will need to be followed up later with additional PRs for:
Nats-FlowCertain details can still be iterated upon as needed.
Signed-off-by: Maurice van Veen [email protected]