Skip to content

Conversation

@Ayush272002
Copy link

Add new port: dotenv

This PR adds a new port for dotenv, a modern C++23 header-only library for loading and parsing .env files at runtime.

Upstream repository: https://github.com/Ayush272002/dotenv
Version added: 1.0.0
License: MIT


✔️ New Port Checklist

  • Changes comply with the maintainer guide.

  • Port name matches the upstream project and follows vcpkg naming conventions.

  • Versioning in vcpkg.json correctly uses version-semver as published by upstream.

  • License in vcpkg.json matches upstream (MIT).

  • Installed copyright file matches upstream LICENSE.

  • Source archive is pulled from an authoritative upstream release tag.

  • Generated usage text is accurate for a header-only library.

  • The version database was updated by running:

    ./vcpkg x-add-version --all
    
  • Only one entry exists for this new port in versions/d-/dotenv.json.

  • Only the added version was appended to versions/baseline.json.


📦 Port Summary

  • Header-only, installed to:

    include/dotenv/dotenv.hpp
    
  • No patches required.

  • No dependencies required.

  • Supports all non-UWP platforms ("supports": "!(uwp)").

@Ayush272002
Copy link
Author

@Ayush272002 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@Ayush272002 Ayush272002 changed the title Add dotenv port (v1.0.0) Add dotenv port (v1.0.1) Dec 2, 2025
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the version database issues have been resolved.

@vicroms vicroms marked this pull request as draft December 4, 2025 03:22
@Ayush272002 Ayush272002 marked this pull request as ready for review December 4, 2025 10:23
Copilot finished reviewing on behalf of Ayush272002 December 4, 2025 10:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new vcpkg port for dotenv v1.0.1, a modern C++23 header-only library for loading and parsing .env files at runtime. The port follows vcpkg conventions for header-only libraries with proper version tracking and MIT license specification.

Key Changes:

  • Adds dotenv port version 1.0.1 with header-only installation
  • Configures the port to support all non-UWP platforms
  • Establishes version tracking in vcpkg's version database

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
versions/d-/dotenv.json Creates initial version entry for dotenv 1.0.1 in the version database
versions/baseline.json Adds dotenv 1.0.1 baseline entry in alphabetically correct position
ports/dotenv/vcpkg.json Defines port metadata including version, description, homepage, and platform support
ports/dotenv/portfile.cmake Implements header-only installation from GitHub release v1.0.1 with copyright file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BillyONeal
Copy link
Member

LGTM once the version database issues have been resolved.

Unfortunately I think we missed that what repology calls 'dotenv' points to https://ports.macports.org/port/dotenv which points to https://github.com/gyf304/dotenv , not https://github.com/Ayush272002/dotenv

@Ayush272002 Would you find naming the port ayush272002-dotenv acceptable? Note that this is only about the name of the port, there is no ask to change header/library/etc. names.

@BillyONeal BillyONeal marked this pull request as draft December 5, 2025 01:54
@Ayush272002
Copy link
Author

LGTM once the version database issues have been resolved.

Unfortunately I think we missed that what repology calls 'dotenv' points to https://ports.macports.org/port/dotenv which points to https://github.com/gyf304/dotenv , not https://github.com/Ayush272002/dotenv

@Ayush272002 Would you find naming the port ayush272002-dotenv acceptable? Note that this is only about the name of the port, there is no ask to change header/library/etc. names.

Would cpp-dotenv be acceptable instead? It clearly indicates it's a C++ library and is shorter than ayush272002-dotenv.

@BillyONeal
Copy link
Member

Would cpp-dotenv be acceptable instead? It clearly indicates it's a C++ library and is shorter than ayush272002-dotenv.

https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories

Common prefixes and suffixes used by C++ and open source projects are not valid disambiguators, some examples include but are not limited to:

  • cpp,
  • free,
  • lib,
  • open,
  • numbers

Even without this maintainer guideline https://github.com/gyf304/dotenv is also written in C so it wouldn't be a very good disambiguator

@Ayush272002
Copy link
Author

Would cpp-dotenv be acceptable instead? It clearly indicates it's a C++ library and is shorter than ayush272002-dotenv.

https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories

Common prefixes and suffixes used by C++ and open source projects are not valid disambiguators, some examples include but are not limited to:

  • cpp,
  • free,
  • lib,
  • open,
  • numbers

Even without this maintainer guideline https://github.com/gyf304/dotenv is also written in C so it wouldn't be a very good disambiguator

That makes sense, I understand the guideline. I'll go with ayush272002-dotenv then. I have updated the PR accordingly.

@Ayush272002 Ayush272002 marked this pull request as ready for review December 5, 2025 21:58
@vicroms vicroms marked this pull request as draft December 6, 2025 09:20
@Ayush272002 Ayush272002 marked this pull request as ready for review December 6, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants