Skip to content

Conversation

@adeelkazmi
Copy link
Contributor

Fixes #47088

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@adeelkazmi adeelkazmi force-pushed the master branch 2 times, most recently from 6a741a1 to b3ea847 Compare September 11, 2025 18:06
@adeelkazmi
Copy link
Contributor Author

@microsoft-github-policy-service agree


set(USE_METAL OFF)
if ("metal" IN_LIST FEATURES)
if ("metal" IN_LIST ALL_FEATURES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: ALL_FEATURES is a thing.
Did you mean to make it default feature? Or set USE_METAL unconditionally on osx | ios?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, apologies, vcpkg noob here, I assumed the supports tag in the vcpkg.json file would handle that appropriately, but evidently not. I'll push another patch to check OS in Cmake.

Copy link
Contributor Author

@adeelkazmi adeelkazmi Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or set USE_METAL unconditionally on osx | iOS?

Hmm, we seem to get a metal flavour on osx regardless of whether this is set or not from what I'm seeing. Seems to get stuck in some sort of hybrid as it's still linking with the metal framework on my Mac.

Perhaps the real issue is elsewhere but at least with this, I get a the full metal build and then no linker errors though I'm a bit puzzled now at the original intention here. How does FEATURES get set etc. and how would we have built for metal before?

Copy link
Contributor Author

@adeelkazmi adeelkazmi Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, found the real issue and fixed it in my latest patch. The issue was two-fold:

  • We use MTLCreateSystemDefaultDevice even if USE_METAL is not defined thus get a linker error for anything that uses Angle built without metal enabled.
  • There are a whole bunch of files which were not compiled in with the Non-Metal build which I've added back in now. This had caused linker errors too as you can imagine.

@adeelkazmi adeelkazmi force-pushed the master branch 2 times, most recently from 6bd5763 to 2a1ce66 Compare September 12, 2025 12:10
@vicroms vicroms merged commit b85445d into microsoft:master Sep 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[angle] Linker failure when using Angle on macOS

3 participants