-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[reactphysics3d] Add new port #47233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89139a5 to
b8ea44c
Compare
b8ea44c to
5ecc1ae
Compare
|
@microsoft-github-policy-service agree |
ports/reactphysics3d/portfile.cmake
Outdated
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| WINDOWS_USE_MSBUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICS the windows problems are from absence of dll exports and not solved by msbuild.
| WINDOWS_USE_MSBUILD |
Insert at the top:
if(VCPKG_TARGET_IS_WINDOWS)
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endifThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that's what I've been seeing online but wanted to try with msbuild, I will disable dll for windows then, thanks !
Co-authored-by: Kai Pastor <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
This reverts commit 55c4481.
Fixes #19309
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.