Skip to content

Conversation

@A13501350
Copy link
Contributor

Fixes #44841 by resolving the CMake build error in yajl port caused by deprecated GET_TARGET_PROPERTY(... LOCATION) usage.

CMake Error at reformatter/CMakeLists.txt:38 (GET_TARGET_PROPERTY):
  The LOCATION property may not be read from target "json_reformat".  Use the
  target name directly with add_custom_command, or use the generator
  expression $<TARGET_FILE>, as appropriate.

CMake Error at verify/CMakeLists.txt:32 (GET_TARGET_PROPERTY):
  The LOCATION property may not be read from target "json_verify".  Use the
  target name directly with add_custom_command, or use the generator
  expression $<TARGET_FILE>, as appropriate.

Appended fixes to the existing cmake.patch, Replaced deprecated GET_TARGET_PROPERTY(LOCATION) with generator expression $<TARGET_FILE> in:

  • verify/CMakeLists.txt
  • reformatter/CMakeLists.txt

Verification

  1. Tested on Windows (x64):
    ./vcpkg install yajl
  2. Build succeeds with:
    • CMake 4.0+
    • Visual Studio 2022
    • Ninja 1.12.1

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@A13501350
Copy link
Contributor Author

@microsoft-github-policy-service agree

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms vicroms merged commit d0acd43 into microsoft:master Aug 27, 2025
18 checks passed
@A13501350 A13501350 deleted the fix/yajl-cmake-location-deprecation branch August 27, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[yajl] Build error on arm64-osx-release

3 participants