[vtk] Fix features and cross builds #46843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
force-pushed
the
vtk-wip
branch
2 times, most recently
from
b72273e to
e7a760a
Compare
... closer to initialization.
In contrast to VTK_FEATURE_OPTIONS, say NO instead of DONT_WANT. This forces features to explicitly model true dependencies and helps avoid hidden installation order problems. Start with feature sql <-> dependency sqlite3.
Group MPI implies mpi requirements for other dependencies.
... and use vcpkg_get_vcpkg_installed_python().
dg0yt
force-pushed
the
vtk-wip
branch
2 times, most recently
from
4fff42f to
39b9c78
Compare
8 tasks
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Sep 3, 2025
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for the fixes! Fingers crossed this also helps with the funny behavior we're seeing on modern macOS :/
Member
|
Unfortunately this breaks now that we fixed conflict detection: Installing 2155/2243 vtk-compile-tools:[email protected]...
Building vtk-compile-tools:[email protected]...
-- Using cached Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz
-- Extracting source D:/downloads/Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz
-- Using source at D:/b/vtk-compile-tools/src/aed1b438af-c216954790.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
-- Building x64-windows-rel
-- Installing: D:/p/vtk-compile-tools_x64-windows/share/vtk-compile-tools/copyright
-- Performing post-build validation
error: The following files are already installed in D:/installed/x64-windows and are in conflict with vtk-compile-tools:x64-windows
Installed by vtk:x64-windows:
bin/vtkWrappingTools-9.3.dll
bin/vtkWrappingTools-9.3.pdb
lib/vtkWrappingTools-9.3.lib
Starting submission of vtk-compile-tools:[email protected] to 1 binary cache(s) in the background
Elapsed time to handle vtk-compile-tools:x64-windows: 21 s
vtk-compile-tools:x64-windows package ABI: 414bb0b5267a2a9a15788c642e98f19e06ba5f657d1b0efae3aa70bdb2d55cc9I'm going to fix for now by adding a ci.baseline.txt that skips vtk-compile-tools on the native platforms in #47198 but we really need a concrete fix for this. |
Member
|
Actually I can't do that because it breaks the cross platforms too :(. I think I'm forced to revert this :( |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Sep 5, 2025
This reverts commit eb2266e / microsoft#46843 Resolves: Installing 2155/2243 vtk-compile-tools:[email protected]... Building vtk-compile-tools:[email protected]... -- Using cached Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz -- Extracting source D:/downloads/Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz -- Using source at D:/b/vtk-compile-tools/src/aed1b438af-c216954790.clean -- Found external ninja('1.12.1'). -- Configuring x64-windows -- Building x64-windows-rel -- Installing: D:/p/vtk-compile-tools_x64-windows/share/vtk-compile-tools/copyright -- Performing post-build validation error: The following files are already installed in D:/installed/x64-windows and are in conflict with vtk-compile-tools:x64-windows Installed by vtk:x64-windows: bin/vtkWrappingTools-9.3.dll bin/vtkWrappingTools-9.3.pdb lib/vtkWrappingTools-9.3.lib Starting submission of vtk-compile-tools:[email protected] to 1 binary cache(s) in the background Elapsed time to handle vtk-compile-tools:x64-windows: 21 s vtk-compile-tools:x64-windows package ABI: 414bb0b5267a2a9a15788c642e98f19e06ba5f657d1b0efae3aa70bdb2d55cc9
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Sep 5, 2025
This reverts commit eb2266e / microsoft#46843 Resolves: Installing 2155/2243 vtk-compile-tools:[email protected]... Building vtk-compile-tools:[email protected]... -- Using cached Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz -- Extracting source D:/downloads/Kitware-VTK-09a76bc55b37caad94d0d8ebe865caaed1b438af.tar.gz -- Using source at D:/b/vtk-compile-tools/src/aed1b438af-c216954790.clean -- Found external ninja('1.12.1'). -- Configuring x64-windows -- Building x64-windows-rel -- Installing: D:/p/vtk-compile-tools_x64-windows/share/vtk-compile-tools/copyright -- Performing post-build validation error: The following files are already installed in D:/installed/x64-windows and are in conflict with vtk-compile-tools:x64-windows Installed by vtk:x64-windows: bin/vtkWrappingTools-9.3.dll bin/vtkWrappingTools-9.3.pdb lib/vtkWrappingTools-9.3.lib Starting submission of vtk-compile-tools:[email protected] to 1 binary cache(s) in the background Elapsed time to handle vtk-compile-tools:x64-windows: 21 s vtk-compile-tools:x64-windows package ABI: 414bb0b5267a2a9a15788c642e98f19e06ba5f657d1b0efae3aa70bdb2d55cc9
Contributor
Author
|
Hm, IIRC the reason why I didn't remove |
Contributor
Author
|
I will wait for the revert to land. At least no need to worry about the revert because using vtk:arm64-windows* downstream in paraview and vtk-dicom needs more work, and now I know that I must put all these ports in one PR. I guess the feature testing was hiding the conflict because after feature testing the changed ports, the vtk-compile-tools artifact was cached, and there was no reason to install both vtk and vtk-compile-tools in a native triplet. (I could use a test port to force installing both, or I can let vtk do that.) |
Member
No, the conflict was hidden because all conflict detection was broken prior to microsoft/vcpkg-tool#1768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable crosscompiling.
Fix feature python.
Devendor gl2ps.
Tighten wiring between features/dependencies and capabilities.
Resolve some feature configuration issues.
Fix wiring of MPI with regard to hdf5 installations with MPI.
Some cleanup.