Skip to content

[qt5,sqlite3] Fix missing pthread flags #46485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicroms merged 2 commits into from
Jul 26, 2025
Merged

[qt5,sqlite3] Fix missing pthread flags #46485

vicroms merged 2 commits into from
Jul 26, 2025

Conversation

@acidx27x
Copy link
Contributor

@acidx27x acidx27x commented Jul 18, 2025

qt5-base:

  • add missing -lpthread for sqlite3 linking libraries. sqlite3 has -pthread flag in pkgconfig Libs but x_vcpkg_pkgconfig_get_modules(PREFIX sqlite3 MODULES sqlite3 LIBRARIES) acquires only string with '-l' prefix and -pthread is ignored

sqlite3:

  • add missing -pthread flag to pkgconfig Cflags

vicroms
vicroms requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@vicroms vicroms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update port versions and run vcpkg x-add-version to update the version database.

@vicroms vicroms marked this pull request as draft July 21, 2025 05:44
@vicroms vicroms added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 21, 2025
dg0yt
dg0yt reviewed Jul 21, 2025
View reviewed changes
@acidx27x acidx27x marked this pull request as ready for review July 22, 2025 14:09
@acidx27x acidx27x requested a review from vicroms July 22, 2025 14:09
@vicroms vicroms merged commit f2e1c41 into microsoft:master Jul 26, 2025
18 checks passed
@ajtribick
Copy link
Contributor

ajtribick commented Jul 26, 2025

This doesn't get detected by vcpkg update - presumably because this updated the git-tree of existing port versions rather than adding new versions. Is that intended?

dg0yt added a commit to dg0yt/vcpkg that referenced this pull request Jul 27, 2025
@dg0yt
Revert "[qt5,sqlite3] Fix missing pthread flags (microsoft#46485)"
15cbbfc 
This reverts commit f2e1c41.
@dg0yt dg0yt mentioned this pull request Jul 27, 2025
Merged
dg0yt pushed a commit to dg0yt/vcpkg that referenced this pull request Jul 28, 2025
@acidx27x @dg0yt
[qt5,sqlite3] Fix missing pthread flags (microsoft#46485)
9c6a174 
Co-authored-by: kirim <[email protected]>
@dg0yt dg0yt mentioned this pull request Jul 28, 2025
Merged
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
@acidx27x @talregev
[qt5,sqlite3] Fix missing pthread flags (microsoft#46485)
213c1ae 
Co-authored-by: kirim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicroms vicroms vicroms approved these changes

+1 more reviewer

@dg0yt dg0yt dg0yt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acidx27x @ajtribick @vicroms @dg0yt