-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[mzying2001-sw] Add new port #46010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mzying2001-sw] Add new port #46010
Conversation
|
@microsoft-github-policy-service agree |
|
Usage passed on |
Co-authored-by: Lily Wang <[email protected]>
BillyONeal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
Hi there, as far as I can tell this one isn't true; sw-gui does not unambiguously refer to this repo. Would you accept mzying2001-sw instead? https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories
Other than the name of the port this looks good to me.
Note that this is a request to change the name of the port, not the name of your library.
Okay, I've changed the port name to |
BillyONeal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new port!
Co-authored-by: Lily Wang <[email protected]>
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.