Skip to content

Conversation

@Mzying2001
Copy link
Contributor

@Mzying2001 Mzying2001 commented Jun 15, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Mzying2001
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Mzying2001 Mzying2001 changed the title Add sw-gui to vcpkg [sw-gui] Add new port Jun 15, 2025
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 16, 2025
@LilyWangLL
Copy link
Contributor

Usage passed on x64-windows.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

Hi there, as far as I can tell this one isn't true; sw-gui does not unambiguously refer to this repo. Would you accept mzying2001-sw instead? https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories

Other than the name of the port this looks good to me.

Note that this is a request to change the name of the port, not the name of your library.

@Mzying2001 Mzying2001 changed the title [sw-gui] Add new port [mzying2001-sw] Add new port Jun 18, 2025
@Mzying2001
Copy link
Contributor Author

[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

Hi there, as far as I can tell this one isn't true; sw-gui does not unambiguously refer to this repo. Would you accept mzying2001-sw instead? https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories

Other than the name of the port this looks good to me.

Note that this is a request to change the name of the port, not the name of your library.

Okay, I've changed the port name to mzying-2001, and updated the version to 0.0.2 because the installation path under share/ changed.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port!

@BillyONeal BillyONeal dismissed LilyWangLL’s stale review June 18, 2025 22:11

The comments were fixed

@BillyONeal BillyONeal merged commit 297f951 into microsoft:master Jun 18, 2025
18 checks passed
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 19, 2025
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants