-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[eigen3] update to 3.4.1-250818 from 3.4.0 #34542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@microsoft-github-policy-service agree |
dg0yt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant as a draft?
Once there is a 3.4.1 release:
Ah yes, that's a better idea! |
|
There seems to be some motion upstream to finally tag a new release. The latest commit on the 3.4 branch now actually defines the version as 3.4.1. Meanwhile, the master defines the version as 3.4.90. |
|
Closed and reopened because GitHub was stuck |
If upstream has officially declared another commit as what is actually 3.4.1 then indeed we would want that to be the one we deploy claiming to be that version. As a result I cancelled PR build because the lab is very behind right now.
That one is up to you; there's nothing wrong with taking the smaller version update and doing a separate PR with a current one. |
|
X.Y.9Z versions are in some world just dev versions. Another example already observed in vcpkg with that versioning was either fontconfig or freetypein the past |
|
Over the last years there have been multiple requests for tagging a new release upstream, but so far nothing came of it: In one of these threads (#2879) a maintainer recommends (mostly) using the latest commit (from master) that passes all their test. Now, one of the many changes between the The most recent changes to the I appended the date of the commit I'm using for this PR to the version to indicate that it's not an official tag. |
|
Also relevant:
|
dg0yt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
LGTM, but somebody else must approve.
|
@BillyONeal What do you think about this update? |
|
Nice, thanks! |
./vcpkg x-add-version --alland committing the result.This PR updates eigen to the most recent commit (from Aug 18, 2025 as of Aug 20, 2025) of the
3.4branch which indicates version3.4.1inEigen/src/Core/util/Macros.h.There is no 3.4.1 tag upstream, but the version was updated in this commit from Nov 5, 2023, see also the discussion below.
The previous patches are all upstream and removed in this PR:
fix-vectorized-reductions-half.patchin b0fe14213ec4c8615de485fe4c2bcd4bab0cbd19remove_configure_checks.patchin f1922b6dac4a9c18b07c26658cea08db80489278update-warning-suppression-to-latest.patchin 34e5f34b391e9b964917d54139aae1ecf522d4e5The
portfile.cmakechanges are mainly the same as in #45295.Full diff log: 3.4.0...cd7263e7f626e75c9210b74d2d6043a8c0519f1c