Skip to content

Conversation

@alxvth
Copy link
Contributor

@alxvth alxvth commented Oct 17, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This PR updates eigen to the most recent commit (from Aug 18, 2025 as of Aug 20, 2025) of the 3.4 branch which indicates version 3.4.1 in Eigen/src/Core/util/Macros.h.
There is no 3.4.1 tag upstream, but the version was updated in this commit from Nov 5, 2023, see also the discussion below.

The previous patches are all upstream and removed in this PR:

The portfile.cmake changes are mainly the same as in #45295.

Full diff log: 3.4.0...cd7263e7f626e75c9210b74d2d6043a8c0519f1c

@alxvth
Copy link
Contributor Author

alxvth commented Oct 17, 2023

@microsoft-github-policy-service agree

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant as a draft?

Once there is a 3.4.1 release:

@alxvth
Copy link
Contributor Author

alxvth commented Oct 17, 2023

Is this meant as a draft?

Once there is a 3.4.1 release:

Ah yes, that's a better idea!

@alxvth alxvth marked this pull request as draft October 17, 2023 14:35
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 18, 2023
@PhoebeHui PhoebeHui assigned Mengna-Li and unassigned FrankXie05 Apr 2, 2025
@BillyONeal BillyONeal marked this pull request as ready for review April 9, 2025 21:18
@alxvth
Copy link
Contributor Author

alxvth commented Apr 10, 2025

There seems to be some motion upstream to finally tag a new release.

The latest commit on the 3.4 branch now actually defines the version as 3.4.1.
That branch did actually not do that yet on the commit I was referring to in this PR. (There used to be a 3.4.1 branch, which apparently was deleted in the meantime).
It might be better to use the most recent commit to the 3.4 branch for 3.4.1 here. What do you think?

Meanwhile, the master defines the version as 3.4.90.

@BillyONeal BillyONeal closed this Apr 10, 2025
@BillyONeal BillyONeal reopened this Apr 10, 2025
@BillyONeal
Copy link
Member

Closed and reopened because GitHub was stuck

@BillyONeal
Copy link
Member

The latest commit on the 3.4 branch now actually defines the version as 3.4.1.
That branch did actually not do that yet on the commit I was referring to in this PR. (There used to be a 3.4.1 branch, which apparently was deleted in the meantime).

If upstream has officially declared another commit as what is actually 3.4.1 then indeed we would want that to be the one we deploy claiming to be that version. As a result I cancelled PR build because the lab is very behind right now.

Meanwhile, the master defines the version as 3.4.90.

That one is up to you; there's nothing wrong with taking the smaller version update and doing a separate PR with a current one.

@BillyONeal BillyONeal marked this pull request as draft April 10, 2025 17:04
@Neumann-A
Copy link
Contributor

X.Y.9Z versions are in some world just dev versions. Another example already observed in vcpkg with that versioning was either fontconfig or freetypein the past

@alxvth alxvth changed the title [eigen3] update to 3.4.1 from 3.4.0 [eigen3] update to 3.4.1-250818 from 3.4.0 Aug 19, 2025
@alxvth alxvth marked this pull request as ready for review August 19, 2025 07:58
@alxvth
Copy link
Contributor Author

alxvth commented Aug 19, 2025

Over the last years there have been multiple requests for tagging a new release upstream, but so far nothing came of it:
libeigen/eigen#2699 (Jul 2023), libeigen/eigen#2702 (Jul 2023), libeigen/eigen#2724 (Oct 2023), libeigen/eigen#2809 (Apr 2024), libeigen/eigen#2845 (Aug 2024), libeigen/eigen#2848 (Aug 2024), libeigen/eigen#2879 (Nov 2024), libeigen/eigen#2907 (Feb 2025).

In one of these threads (#2879) a maintainer recommends (mostly) using the latest commit (from master) that passes all their test. Now, one of the many changes between the 3.4 branch and the current upstream master is the minimum required c++ version (c++14 vs c++03). It would be great to list one version of eigen in vcpkg that contains the by now 200+ build and runtime fix commits from the 3.4 branch since the 3.4.0 tag, before (at some point hopefully) moving closer to the master branch.

The most recent changes to the 3.4 branch in the previous six months were either CI fixes or upstream-merges of patches that I wrote for this PR. It seems fair to say that the branch is rather stable and the latest commit on it a good candidate for indexing here.

I appended the date of the commit I'm using for this PR to the version to indicate that it's not an official tag.

@alxvth
Copy link
Contributor Author

alxvth commented Aug 20, 2025

Also relevant:

@alxvth alxvth requested a review from dg0yt August 21, 2025 06:37
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
LGTM, but somebody else must approve.

@alxvth
Copy link
Contributor Author

alxvth commented Aug 25, 2025

@BillyONeal What do you think about this update?

@vicroms vicroms merged commit 120deac into microsoft:master Aug 27, 2025
18 checks passed
@alxvth
Copy link
Contributor Author

alxvth commented Aug 27, 2025

Nice, thanks!

@alxvth alxvth mentioned this pull request Sep 25, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants