Skip to content

Conversation

@MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Feb 13, 2023

Fixes #29456. Use <cctype> instead of <ctype.h> to solve the following error:

e:\code\vcpkg\buildtrees\seacas\src\76a825bc51-907a76ce33.clean\packages\seacas\libraries\ioss\src\text_mesh\Iotm_TextMeshFuncs.h(66): error C2039: 'isspace': is not a member of 'std'
D:\Program Files\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\numeric(14): note: see declaration of 'std'
e:\code\vcpkg\buildtrees\seacas\src\76a825bc51-907a76ce33.clean\packages\seacas\libraries\ioss\src\text_mesh\Iotm_TextMeshFuncs.h(68): error C2039: 'isspace': is not a member of 'std'
D:\Program Files\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\numeric(14): note: see declaration of 'std'
e:\code\vcpkg\buildtrees\seacas\src\76a825bc51-907a76ce33.clean\packages\seacas\libraries\ioss\src\text_mesh\Iotm_TextMeshFuncs.h(106): error C2039: 'isdigit': is not a member of 'std'
D:\Program Files\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\numeric(14): note: see declaration of 'std'

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Feb 13, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 13, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review February 15, 2023 02:46
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 16, 2023
@JavierMatosD JavierMatosD merged commit 01da3c4 into microsoft:master Feb 16, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_seacas branch February 17, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[seacas] Build error

3 participants