Skip to content

[Simd] Add missing header files #28376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicroms merged 4 commits into from
Dec 28, 2022
Merged

[Simd] Add missing header files #28376

vicroms merged 4 commits into from
Dec 28, 2022

Conversation

@JonLiu1993
Copy link
Contributor

@JonLiu1993 JonLiu1993 commented Dec 16, 2022

Describe the pull request

When install simd, only SimdLib.hpp, missing a lot of header files. I add the missing header files.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 16, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 16, 2022
View reviewed changes
Thomas1664
Thomas1664 reviewed Dec 16, 2022
View reviewed changes
Thomas1664
Thomas1664 reviewed Dec 16, 2022
View reviewed changes
@Thomas1664
Copy link
Contributor

Thomas1664 commented Dec 16, 2022

Furthermore, this port has a CMake build system: https://github.com/ermig1979/Simd/blob/96dfde3b243687d796426719cf354b47fd4cd727/prj/cmake/CMakeLists.txt

@JonLiu1993
Copy link
Contributor Author

JonLiu1993 commented Dec 22, 2022

Furthermore, this port has a CMake build system: https://github.com/ermig1979/Simd/blob/96dfde3b243687d796426719cf354b47fd4cd727/prj/cmake/CMakeLists.txt

We will not consider replacing the cmake build system for this PR, maybe the next version update will consider doing so.

@JonLiu1993 JonLiu1993 marked this pull request as ready for review December 22, 2022 09:22
@JonLiu1993 JonLiu1993 requested a review from Adela0814 December 22, 2022 10:02
@Adela0814 Adela0814 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Dec 23, 2022
@vicroms vicroms merged commit fa0931a into microsoft:master Dec 28, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/simd branch December 29, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicroms vicroms vicroms left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@Thomas1664 Thomas1664 Thomas1664 left review comments

@Adela0814 Adela0814 Adela0814 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Adela0814 Adela0814

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Simd] Missing header files

4 participants

@JonLiu1993 @Thomas1664 @vicroms @Adela0814