Skip to content

Conversation

@piotrwendykier
Copy link
Contributor

@piotrwendykier piotrwendykier commented Dec 2, 2022

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@piotrwendykier
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Wolfram Research"]

@piotrwendykier
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Wolfram Research"]

@microsoft-github-policy-service agree company="Wolfram Research"

@piotrwendykier piotrwendykier marked this pull request as ready for review December 2, 2022 19:41
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 5, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for arrow have changed but the version was not updated
version: 10.0.1#2
old SHA: 17a6dcf45106fee16c59bdc14c38d69d23ccf084
new SHA: ea9873418e3de2180518389baa3562084a566702
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@piotrwendykier
Copy link
Contributor Author

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

I don't understand this comment. I have manually bumped port-version in ports/arrow/vcpkg.json and versions/baseline.json and then run ./vcpkg x-add-version --all.

@FrankXie05
Copy link
Contributor

@piotrwendykier After all the changes are made, you need to submit a commit separately. Don't worry that I will update it. :)

@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 8, 2022
@piotrwendykier
Copy link
Contributor Author

I assume there is nothing else I can do here. Somebody with the write access should merge this PR.

@dan-shaw dan-shaw merged commit 4b6b7f4 into microsoft:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[arrow] CMake config files for Dataset are not copied to the install directory

3 participants