-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Fix for issue #28120. #28122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #28120. #28122
Conversation
|
@microsoft-github-policy-service agree [company="Wolfram Research"] |
@microsoft-github-policy-service agree company="Wolfram Research" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for arrow have changed but the version was not updated
version: 10.0.1#2
old SHA: 17a6dcf45106fee16c59bdc14c38d69d23ccf084
new SHA: ea9873418e3de2180518389baa3562084a566702
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
I don't understand this comment. I have manually bumped port-version in ports/arrow/vcpkg.json and versions/baseline.json and then run |
|
@piotrwendykier After all the changes are made, you need to submit a commit separately. Don't worry that I will update it. :) |
|
I assume there is nothing else I can do here. Somebody with the write access should merge this PR. |
Describe the pull request
What does your PR fix?
Fixes [arrow] CMake config files for Dataset are not copied to the install directory #28120
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/