[zint] Initial port #27836

koprok · 2022-11-15T21:41:15Z

Add initial port of zint library

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

LilyWangLL · 2022-11-18T09:35:28Z

When I test usage locally, there are the following error. I installed zint[core,png]:x64-windows.

1> [CMake] CMake Error at E:/Lily/zint/installed/x64-windows/share/unofficial-zint/unofficial-zint-config.cmake:60 (set_target_properties):
1> [CMake]   The link interface of target "unofficial::zint::zint" contains:
1> [CMake] 
1> [CMake]     PNG::PNG
1> [CMake] 
1> [CMake]   but the target was not found.  Possible reasons include:
1> [CMake] 
1> [CMake]     * There is a typo in the target name.
1> [CMake]     * A find_package call is missing for an IMPORTED target.
1> [CMake]     * An ALIAS target is missing.

koprok · 2022-11-18T10:46:37Z

@LilyWangLL, you have to call find_package(PNG) too. I believe there are other ports that require similar approach. If not, then can you give me an example how to handle such dependencies?

koprok · 2022-11-18T12:21:40Z

@LilyWangLL, maybe I found it myself. I have to patch the upstream CMakeLists.txt to install unofficial-zint-config.cmake that calls find_package(PNG) and includes the CMake's automatically generated unofficial-zint-targets.cmake. Is this what is expected to do, please confirm?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 90b5fb836cda4eba4569a123bca63b957f55232b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1796b1c..00f49f2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -8246,7 +8246,7 @@
     },
     "zint": {
       "baseline": "2.11.1",
-      "port-version": 0
+      "port-version": 1
     },
     "zkpp": {
       "baseline": "0.2.3",
diff --git a/versions/z-/zint.json b/versions/z-/zint.json
index 982b6d0..f702079 100644
--- a/versions/z-/zint.json
+++ b/versions/z-/zint.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "30cc6feb5be64598ab25709e917cacdfc5cb099c",
+      "version": "2.11.1",
+      "port-version": 1
+    },
     {
       "git-tree": "49e212523ce2c8337e7c7517c759a46805614638",
       "version": "2.11.1",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 7d9775a3c3ffef3cbad688d7271a06803d3a2f51 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1796b1c..00f49f2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -8246,7 +8246,7 @@
     },
     "zint": {
       "baseline": "2.11.1",
-      "port-version": 0
+      "port-version": 1
     },
     "zkpp": {
       "baseline": "0.2.3",
diff --git a/versions/z-/zint.json b/versions/z-/zint.json
index 982b6d0..f702079 100644
--- a/versions/z-/zint.json
+++ b/versions/z-/zint.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "30cc6feb5be64598ab25709e917cacdfc5cb099c",
+      "version": "2.11.1",
+      "port-version": 1
+    },
     {
       "git-tree": "49e212523ce2c8337e7c7517c759a46805614638",
       "version": "2.11.1",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

koprok · 2022-11-18T13:47:45Z

@LilyWangLL, it's fixed now, you should not need to manually call find_package(PNG) any more.

ports/zint/vcpkg.json

scripts/ci.baseline.txt

versions/z-/zint.json

ports/zint/0003-fix-parallel-configure.patch

ports/zint/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for zint have changed but the version was not updated
version: 2.11.1
old SHA: 49e212523ce2c8337e7c7517c759a46805614638
new SHA: 0612462e38337a28ba94c74ded489552c758b808
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 7d9775a3c3ffef3cbad688d7271a06803d3a2f51 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 444d903..8c05845 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -8258,7 +8258,7 @@
     },
     "zint": {
       "baseline": "2.11.1",
-      "port-version": 1
+      "port-version": 0
     },
     "zkpp": {
       "baseline": "0.2.3",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for zint have changed but the version was not updated
version: 2.11.1
old SHA: 49e212523ce2c8337e7c7517c759a46805614638
new SHA: 0612462e38337a28ba94c74ded489552c758b808
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 7d9775a3c3ffef3cbad688d7271a06803d3a2f51 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 444d903..8c05845 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -8258,7 +8258,7 @@
     },
     "zint": {
       "baseline": "2.11.1",
-      "port-version": 1
+      "port-version": 0
     },
     "zkpp": {
       "baseline": "0.2.3",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/zint/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for zint have changed but the version was not updated
version: 2.11.1
old SHA: 0612462e38337a28ba94c74ded489552c758b808
new SHA: 8e8366d2cfa100efb7f4026664f7168cdef88077
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

ports/zint/portfile.cmake

ports/zint/0001-fix-static-lib.patch

JavierMatosD · 2022-11-23T18:35:30Z

Thank you!

github-actions bot previously approved these changes Nov 15, 2022

View reviewed changes

koprok dismissed github-actions[bot]’s stale review via bb5f297 November 15, 2022 21:59

koprok force-pushed the zint branch from 7ecc6cf to bb5f297 Compare November 15, 2022 21:59

github-actions bot previously approved these changes Nov 15, 2022

View reviewed changes

koprok marked this pull request as ready for review November 15, 2022 22:05

FrankXie05 assigned LilyWangLL Nov 16, 2022

LilyWangLL added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:all-feature-testing labels Nov 16, 2022

LilyWangLL added the requires:author-response label Nov 18, 2022

LilyWangLL assigned FrankXie05 Nov 18, 2022

koprok dismissed github-actions[bot]’s stale review via 729ab28 November 18, 2022 13:36

github-actions bot requested changes Nov 18, 2022

View reviewed changes

koprok force-pushed the zint branch from 729ab28 to 7b71fa7 Compare November 18, 2022 13:39

github-actions bot requested changes Nov 18, 2022

View reviewed changes

koprok force-pushed the zint branch from 7b71fa7 to 1656c01 Compare November 18, 2022 13:42

github-actions bot previously approved these changes Nov 18, 2022

View reviewed changes

FrankXie05 suggested changes Nov 21, 2022

View reviewed changes

koprok dismissed github-actions[bot]’s stale review via 3aba570 November 21, 2022 07:56

github-actions bot requested changes Nov 21, 2022

View reviewed changes

koprok force-pushed the zint branch from 7d975b8 to 773452d Compare November 21, 2022 08:08

github-actions bot previously approved these changes Nov 21, 2022

View reviewed changes

koprok dismissed github-actions[bot]’s stale review via 43aa953 November 21, 2022 08:24

koprok force-pushed the zint branch from 773452d to 43aa953 Compare November 21, 2022 08:24

github-actions bot previously approved these changes Nov 21, 2022

View reviewed changes

koprok requested a review from FrankXie05 November 21, 2022 08:40

koprok dismissed github-actions[bot]’s stale review via 38b1cd0 November 21, 2022 08:47

koprok force-pushed the zint branch from 43aa953 to 38b1cd0 Compare November 21, 2022 08:47

github-actions bot requested changes Nov 21, 2022

View reviewed changes

koprok force-pushed the zint branch from 38b1cd0 to abbf248 Compare November 21, 2022 08:47

github-actions bot previously approved these changes Nov 21, 2022

View reviewed changes

koprok dismissed github-actions[bot]’s stale review via 68917d3 November 21, 2022 08:52

koprok force-pushed the zint branch from abbf248 to 68917d3 Compare November 21, 2022 08:52

github-actions bot previously approved these changes Nov 21, 2022

View reviewed changes

FrankXie05 suggested changes Nov 21, 2022

View reviewed changes

ports/zint/portfile.cmake Outdated Show resolved Hide resolved

ports/zint/0001-fix-static-lib.patch Outdated Show resolved Hide resolved

koprok requested a review from FrankXie05 November 21, 2022 09:17

[zint] Initial port

a2c758f

koprok dismissed github-actions[bot]’s stale review via a2c758f November 21, 2022 09:24

koprok force-pushed the zint branch from 68917d3 to a2c758f Compare November 21, 2022 09:24

github-actions bot approved these changes Nov 21, 2022

View reviewed changes

FrankXie05 approved these changes Nov 21, 2022

View reviewed changes

FrankXie05 removed the requires:author-response label Nov 21, 2022

LilyWangLL approved these changes Nov 23, 2022

View reviewed changes

LilyWangLL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Nov 23, 2022

JavierMatosD merged commit 5fe0ac0 into microsoft:master Nov 23, 2022

koprok deleted the zint branch November 23, 2022 20:56

lukaszmoroz pushed a commit to lukaszmoroz/vcpkg that referenced this pull request Nov 24, 2022

[zint] Initial port (microsoft#27836)

53cf16a

[zint] Initial port #27836

[zint] Initial port #27836

Uh oh!

Conversation

koprok commented Nov 15, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

LilyWangLL commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koprok commented Nov 18, 2022

Uh oh!

koprok commented Nov 18, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

koprok commented Nov 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JavierMatosD commented Nov 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LilyWangLL commented Nov 18, 2022 •

edited

Loading