[curl] Update to 7.86.0 #27778
[curl] Update to 7.86.0 #27778
Conversation
|
@microsoft-github-policy-service agree |
|
I notice that multiple workflows failed. Looking at the logs, I can see that curl (which I updated) is seemingly passing. Are the failures unrelated to my changes? Or are they caused by other packages which are dependent on curl, which for some reason fail due to my changes? Any advice would be appreciated! 🙂 |
|
Your PR looks good. However, upstream changes (in CURL) may have changed usage requirements. This often shows up only when a downstream port builds executables (resolving all static libs). |
|
You can download failure logs to see what exactly has failed.
|
|
Thanks a lot for the advice! I will investigate. |
FrankXie05
added
the
category:port-update
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much for submitting this PR :). It seems to be an error of |
|
Thank you @FrankXie05 ! After spending a couple of hours on this though, I can't say that I am any wiser. The OpenSSL problem I can reproduce on my Linux machine, but I have no idea what is causing it. I don't know how to proceed with this, and I think I need to admit defeat on this one. My cmake and vcpkg skills are simply too lacking. Should I close the PR, or do you want to keep it open for the case that someone else wants to take over? |
|
@Znurre Never mind, I will take over this PR. :) |
Filed upstream as Azure/azure-sdk-for-cpp#4127
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/aws-sdk-cpp/vcpkg.json
Valid values for the license field can be found in the documentation
|
I am not sure why check_cxx_source_runs seems to hate private dependencies; aws sdk's CMake is ... strange. I think the break was caused by curl/curl#9125 . I pushed a change that works around the problem by locking the selected curl features, thus eliminating the need for check_cxx_source_runs in the first place. |
|
Also, I am super not confident that 98e3bbb is correct; I would appreciate other reviwers. |
…t/vcpkg#27778 (#4127) Curl is no longer publishing that it depends on ws2_32 when dynamically linked. Azure Core directly uses Ws2_32 things, so it needs that declared dependency. For example: https://github.com/Azure/azure-sdk-for-cpp/blob/90fc46693f4b90b805047f165c0b41e07e867594/sdk/core/azure-core/src/http/curl/curl.cpp#L165
FrankXie05
added
the
info:needs-maintainer-attention
|
Thank you! |
* [curl] Update to 7.86.0 * [azure-core-cpp] Add missing Ws2_32.lib. Filed upstream as Azure/azure-sdk-for-cpp#4127 * [aws-sdk-cpp] Lock the selected curl features. Co-authored-by: FrankXie <[email protected]> Co-authored-by: Billy Robert O'Neal III <[email protected]>
6 participants
Update curl to version 7.86.0
What does your PR fix?
Bumps the version of curl to 7.86.0 and adds WebSockets as a feature
Which triplets are supported/not supported? Have you updated the CI baseline?
No, unchanged.
Does your PR follow the maintainer guide?
I think so. I have done my best to conform, but this is my first contribution, so please be kind :)
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/