[zycore] Add new port #27195
[zycore] Add new port #27195
Conversation
JonLiu1993
added
the
category:new-port
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/zycore/vcpkg.json
Valid values for the license field can be found in the documentation
|
Please consider adding a "license" field to the |
Co-authored-by: JonLiu1993 <[email protected]>
|
Seems I submitted some redundant commits... Forgive me, I'm new to vcpkg😢. |
Co-authored-by: Florian Bernd <[email protected]>
fre3dm4n
requested review from
JonLiu1993 and
flobernd
and removed request for
JonLiu1993 and
flobernd
|
Tetsed zycore:x64-windows usage successfully. |
JonLiu1993
added
info:needs-maintainer-attention
ports/zycore/fix-install.patch
Outdated
| - ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| - LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}) | ||
| + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| + RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} |
There was a problem hiding this comment.
This patch can be minimized. We only need to insert RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} in the middle.
ports/zycore/portfile.cmake
Outdated
|
|
||
|
|
||
| vcpkg_cmake_config_fixup( | ||
| CONFIG_PATH lib/cmake/${PORT} |
There was a problem hiding this comment.
Please don't use the PORT variable here. CONFIG_PATH is a source path. It doesn't depend on the value of PORT but on the literal name chosen by the package.
ports/zycore/portfile.cmake
Outdated
| CONFIG_PATH lib/cmake/${PORT} | ||
| ) | ||
|
|
||
| configure_file(${SOURCE_PATH}/LICENSE "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" COPYONLY) |
There was a problem hiding this comment.
For consistency in all ports, I would prever to see copyrigh handled in the last line. The common pattern is file(INSTALL ... DESTINATION ... RENAME "copyright") but now there is also a vcpkg_install_copyright command.
fre3dm4n
dismissed stale reviews from github-actions[bot] and JonLiu1993
via
8673956
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Thanks for the update and the patience.
5 participants
Describe the pull request
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
all ,Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/