Skip to content

Conversation

@RealTimeChris
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    It adds support for connecting two voice-chats via a UDP connection between two bots, as well as a few other minor fixes.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

linux-x64, windows-x64, Yes.

Yes it does, I believe.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes I have.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for discordcoreapi have changed but the version was not updated
version: 2022-08-07
old SHA: 2bb3f7b7c12a9eff3ffd36065f59654c9da97ef4
new SHA: 38ba9346ed7a24da249f8c039c303556493450e4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 7, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for discordcoreapi have changed but the version was not updated
version: 2022-08-07
old SHA: 8404e80cbe52474b63d46b26f4547fcb8b50de2e
new SHA: c8b1d3db7715c1d9f15a62d5fede388cddb8ef43
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Aug 8, 2022
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 8, 2022
@Cheney-W Cheney-W removed their assignment Aug 8, 2022
@BillyONeal BillyONeal merged commit 3c2ab5f into microsoft:master Aug 8, 2022
@BillyONeal
Copy link
Member

Thanks!

@RealTimeChris
Copy link
Contributor Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants