Skip to content

[blake3] Add assembly implementations #25921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillyONeal merged 2 commits into from
Jul 25, 2022
Merged

[blake3] Add assembly implementations #25921

BillyONeal merged 2 commits into from
Jul 25, 2022

Conversation

@yuriy-odonnell-epic
Copy link
Contributor

@yuriy-odonnell-epic yuriy-odonnell-epic commented Jul 22, 2022 •
edited
Loading

  • What does your PR fix?

    Adds assembly implementations of the library, which are significantly faster compared to intrinsics.
    Measured single-threaded performance increase from ~2.7GB/s to ~3.6GB/s on AMD 3995WX, Windows, MSVC.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
View reviewed changes
@yuriy-odonnell-epic yuriy-odonnell-epic marked this pull request as ready for review July 22, 2022 01:27
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 22, 2022
FrankXie05
FrankXie05 suggested changes Jul 22, 2022
View reviewed changes
@FrankXie05 FrankXie05 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jul 25, 2022
@BillyONeal BillyONeal merged commit 09d4f8e into microsoft:master Jul 25, 2022
@BillyONeal
Copy link
Member

BillyONeal commented Jul 25, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FrankXie05 FrankXie05

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuriy-odonnell-epic @BillyONeal @FrankXie05