[blake3] Add new port #25787
Merged
[blake3] Add new port #25787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
I've tested this port locally in my application, however I'm only able to test Windows at this point. I'll squash/rebase it when it passes the reviews. |
Contributor
Author
|
Potentially in the future this port should be updated to use BLAKE3-s own CMake script, when/if BLAKE3-team/BLAKE3#247 is merged. |
JonLiu1993
added
category:new-port
yuriy-odonnell-epic
force-pushed
the
new-port-blake3
branch
from
12b3350 to
4071d0d
Compare
Contributor
Author
|
Rebased and squashed. |
Contributor
Author
|
Is there anything preventing this from merging? I'm confused by |
JonLiu1993
approved these changes
Jul 18, 2022
JonLiu1993
added
the
info:needs-maintainer-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds blake3 hash port
Fixes [New Port Request] BLAKE3 #20023
Which triplets are supported/not supported? Have you updated the CI baseline?
All, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes