Deduplicate the recursive file enumeration when installing packages. #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
force-pushed
the
dedupe-file-lists
branch
from
9c3578a to
219f829
Compare
BillyONeal
force-pushed
the
dedupe-file-lists
branch
from
219f829 to
e23dba6
Compare
BillyONeal
commented
Aug 28, 2025
|
|
||
| if (ec) | ||
| { | ||
| msg::println_warning(format_filesystem_call_error(ec, "symlink_status", {file})); |
Member
Author
There was a problem hiding this comment.
This fixed always claiming to be symlink_status if status is used.
|
|
||
| const size_t prefix_length = source_dir.native().size(); | ||
| const Path& destination = destination_dir.destination(); | ||
| std::string destination_subdirectory = destination.filename().to_string(); |
Member
Author
There was a problem hiding this comment.
Note former destination_subdirectory is now triplet_canonical_name.
ras0219-msft
previously approved these changes
Aug 28, 2025
Co-authored-by: Robert Schumacher <[email protected]>
vicroms
approved these changes
Aug 29, 2025
vicroms
pushed a commit
to vicroms/vcpkg-tool
that referenced
this pull request
Oct 9, 2025
…icrosoft#1770) Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a second recursive disk enumeration when installing a package.