Fix cross-device rename_or_delete #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
commented
May 4, 2025
Comment on lines
-2041
to
+2042
| ec == std::make_error_condition(std::errc::file_exists) || this->exists(new_path, ec)) | ||
| ec == std::make_error_condition(std::errc::file_exists) || this->exists(new_path, local_ec)) |
Contributor
Author
There was a problem hiding this comment.
Overwriting ec here broke reaching the early return false for std::errc::cross_device_link in the next if else block.
Contributor
Author
There was a problem hiding this comment.
I chose to use a separate variable to be safe for future additions.
And I just found that such a "future addition" already happened in the past: #1659.
Contributor
Author
There was a problem hiding this comment.
BTW the forced formatting didn't let me put the trailing this->exists on a new line were it would be much more obvious...
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 10.1 seconds delay for each file write operation across devices, e.g. for
FilesWriteBinaryProvider.Fixes microsoft/vcpkg#45130.