Skip to content

Conversation

@autoantwort
Copy link
Contributor

Command to verify the sha entries in the vcpkg-tools.json file.

@autoantwort autoantwort marked this pull request as draft April 23, 2025 20:06
@Osyotr
Copy link
Contributor

Osyotr commented Apr 23, 2025

Would be awesome to also allow passing tool names to skip downloading other tools. Useful when updating e.g. python.

@autoantwort
Copy link
Contributor Author

I have implemented --only-for-name and --fix locally.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it but I think it should be z-; no reason for 'ordinary' customers to touch it so no reason to document / localize it like normal commands.

@autoantwort
Copy link
Contributor Author

autoantwort commented Apr 24, 2025

Oh saw this comment too late. Just finished localizing

@autoantwort autoantwort marked this pull request as ready for review April 24, 2025 20:30
@BillyONeal
Copy link
Member

Oh saw this comment too late. Just finished localizing

I mean, if you already did the work we aren't going to turn it away 🙃

@BillyONeal BillyONeal changed the title WIP: Add x-check-tools-sha Add z-check-tools-sha Apr 29, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) April 29, 2025 19:24
@BillyONeal
Copy link
Member

Thanks for the new command!

@BillyONeal BillyONeal disabled auto-merge April 29, 2025 20:24
@BillyONeal BillyONeal enabled auto-merge (squash) April 29, 2025 20:24
@BillyONeal BillyONeal merged commit a94e984 into microsoft:main Apr 29, 2025
7 checks passed
@autoantwort autoantwort deleted the feature/add-command-to-verify-shas-in-vcpkg-tools-json branch April 29, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants