--clean-buildtrees-after-build: Only clean on success

[autoantwort]

This helps debugging build failures since the buildtrees folder is not removed in that case.

[dg0yt]

Fixing the log confusion I mentioned at the end of microsoft/vcpkg#45070 (comment)? 🙏

[autoantwort]

My assumption was/is that the buildtrees folder is cleared before a build is done.

[autoantwort]

Fixing the log confusion I mentioned at the end of microsoft/vcpkg#45070 (comment)? 🙏

I have created #1657

[BillyONeal]

Should this just be the behavior always?

[dg0yt]

Should this just be the behavior always?

Not always. In my local builds, I do want to be able to compare the logs for different triplets.

[autoantwort]

And afaik the buildtrees folder is needed if you want to step with the debugger into the lib and want code.

[BillyONeal]

Not always. In my local builds, I do want to be able to compare the logs for different triplets.

Sorry, I mean, if someone uses --clean-buildtrees-after-build, it seems like we should only actually do the 'cleaning' on success.

[BillyONeal]

@vicroms @ras0219-msft @JavierMatosD @AugP and I discussed today.

@BillyONeal The point is on failure we tell people to look in buildtrees which is meaningless if we deleted it.

@JavierMatosD "I actually stopped using [--clean-buildtrees-after-build] for that reason"

We would like the existing behavior of --clean-buildtrees-after-build to not clean when the build fails rather than adding a new switch.

[autoantwort]

Sounds good. Have implemented that.

[BillyONeal]

Thanks!