Fix unquote (#2338)

Author: gabritto

internal/stringutil/util.go

@@ -217,7 +217,7 @@ func StripQuotes(name string) string {
 	return name
 }
 
-var matchSlashSomething = regexp.MustCompile(`\.`)
+var matchSlashSomething = regexp.MustCompile(`\\.`)
 
 func matchSlashReplacer(in string) string {
 	return in[1:]

testdata/baselines/reference/submodule/compiler/classStaticPropertyAccess.symbols

@@ -5,7 +5,7 @@ class A {
 >A : Symbol(A, Decl(classStaticPropertyAccess.ts, 0, 0))
 
     public static "\""() {}
->"\"" : Symbol(A["\\\""], Decl(classStaticPropertyAccess.ts, 0, 9))
+>"\"" : Symbol(A["\""], Decl(classStaticPropertyAccess.ts, 0, 9))
 
     public static x: number = 1;
 >x : Symbol(A.x, Decl(classStaticPropertyAccess.ts, 1, 27))

testdata/baselines/reference/submodule/compiler/classStaticPropertyAccess.symbols.diff

@@ -25,7 +25,7 @@ class C236 {
 >C236 : Symbol(C236, Decl(numericClassMembers1.ts, 8, 1))
 
     '0.0' = 1;
->'0.0' : Symbol(C236["00"], Decl(numericClassMembers1.ts, 10, 12))
+>'0.0' : Symbol(C236["0.0"], Decl(numericClassMembers1.ts, 10, 12))
 
     '0' = 2;
 >'0' : Symbol(C236["0"], Decl(numericClassMembers1.ts, 11, 14))

testdata/baselines/reference/submodule/compiler/numericClassMembers1.symbols

@@ -5,7 +5,7 @@
 
      '0.0' = 1;
 ->'0.0' : Symbol(C236['0.0'], Decl(numericClassMembers1.ts, 10, 12))
-+>'0.0' : Symbol(C236["00"], Decl(numericClassMembers1.ts, 10, 12))
++>'0.0' : Symbol(C236["0.0"], Decl(numericClassMembers1.ts, 10, 12))
 
      '0' = 2;
 ->'0' : Symbol(C236['0'], Decl(numericClassMembers1.ts, 11, 14))

testdata/baselines/reference/submodule/compiler/numericClassMembers1.symbols.diff

@@ -16,13 +16,13 @@ class C {
 >"-1" : Symbol(C["-1"], Decl(propertiesAndIndexersForNumericNames.ts, 5, 34))
 
     public "-2.5": string = "negative number"; // Error
->"-2.5" : Symbol(C["-25"], Decl(propertiesAndIndexersForNumericNames.ts, 6, 44))
+>"-2.5" : Symbol(C["-2.5"], Decl(propertiesAndIndexersForNumericNames.ts, 6, 44))
 
     public "3.141592": string = "pi-sitive number"; // Error
->"3.141592" : Symbol(C["3141592"], Decl(propertiesAndIndexersForNumericNames.ts, 7, 46))
+>"3.141592" : Symbol(C["3.141592"], Decl(propertiesAndIndexersForNumericNames.ts, 7, 46))
 
     public "1.2e-20": string = "really small number"; // Error
->"1.2e-20" : Symbol(C["12e-20"], Decl(propertiesAndIndexersForNumericNames.ts, 8, 51))
+>"1.2e-20" : Symbol(C["1.2e-20"], Decl(propertiesAndIndexersForNumericNames.ts, 8, 51))
 
     public "Infinity": string = "A gillion"; // Error
 >"Infinity" : Symbol(C["Infinity"], Decl(propertiesAndIndexersForNumericNames.ts, 9, 53))
@@ -94,6 +94,6 @@ class C {
 >"0b101101001010" : Symbol(C["0b101101001010"], Decl(propertiesAndIndexersForNumericNames.ts, 37, 47))
 
     public "0.000000000000000000012": string = "should've been in exponential form"; // No error
->"0.000000000000000000012" : Symbol(C["0000000000000000000012"], Decl(propertiesAndIndexersForNumericNames.ts, 38, 56))
+>"0.000000000000000000012" : Symbol(C["0.000000000000000000012"], Decl(propertiesAndIndexersForNumericNames.ts, 38, 56))
 }
 

testdata/baselines/reference/submodule/compiler/propertiesAndIndexersForNumericNames.symbols

@@ -13,7 +13,7 @@ module JustStrings {
 
     class T { '1.': string; }
 >T : Symbol(T, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 4, 28))
->'1.' : Symbol(T["1"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
+>'1.' : Symbol(T["1."], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
 
     var s: S;
 >s : Symbol(s, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 6, 7))
@@ -30,7 +30,7 @@ module JustStrings {
 
     interface T2 { '1.0': string; baz?: string }
 >T2 : Symbol(T2, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 9, 46))
->'1.0' : Symbol(T2["10"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
+>'1.0' : Symbol(T2["1.0"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
 >baz : Symbol(T2.baz, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 33))
 
     var s2: S2;

testdata/baselines/reference/submodule/compiler/propertiesAndIndexersForNumericNames.symbols.diff

@@ -10,7 +10,7 @@
      class T { '1.': string; }
  >T : Symbol(T, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 4, 28))
 ->'1.' : Symbol(T['1.'], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
-+>'1.' : Symbol(T["1"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
++>'1.' : Symbol(T["1."], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
 
      var s: S;
  >s : Symbol(s, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 6, 7))
@@ -25,7 +25,7 @@
      interface T2 { '1.0': string; baz?: string }
  >T2 : Symbol(T2, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 9, 46))
 ->'1.0' : Symbol(T2['1.0'], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
-+>'1.0' : Symbol(T2["10"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
++>'1.0' : Symbol(T2["1.0"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
  >baz : Symbol(T2.baz, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 33))
 
      var s2: S2;

testdata/baselines/reference/submodule/conformance/assignmentCompatWithObjectMembersStringNumericNames.symbols

@@ -41,10 +41,10 @@ class C {
 >2.0 : Symbol(C[2.0], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 16, 16))
 
     "3.0": string; // ok
->"3.0" : Symbol(C["30"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 17, 16))
+>"3.0" : Symbol(C["3.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 17, 16))
 
     "4.0": number; // error
->"4.0" : Symbol(C["40"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 18, 18))
+>"4.0" : Symbol(C["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 18, 18))
 
     3.0: MyNumber // error
 >3.0 : Symbol(C[3.0], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 19, 18))
@@ -116,10 +116,10 @@ interface I {
 >foo : Symbol(I.foo, Decl(numericIndexerConstrainsPropertyDeclarations.ts, 51, 15))
 
     "3.0": string; // ok
->"3.0" : Symbol(I["30"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 52, 18))
+>"3.0" : Symbol(I["3.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 52, 18))
 
     "4.0": number; // error
->"4.0" : Symbol(I["40"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 53, 18))
+>"4.0" : Symbol(I["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 53, 18))
 
     f: MyNumber; // error
 >f : Symbol(I.f, Decl(numericIndexerConstrainsPropertyDeclarations.ts, 54, 18))