Also delete GetGlobalDiagnostics

Author: jakebailey

internal/compiler/program.go

@@ -456,7 +456,11 @@ func (p *Program) GetBindDiagnostics(ctx context.Context, sourceFile *ast.Source
 }
 
 func (p *Program) GetSemanticDiagnostics(ctx context.Context, sourceFile *ast.SourceFile) []*ast.Diagnostic {
-	return p.collectDiagnostics(ctx, sourceFile, true /*concurrent*/, p.getSemanticDiagnosticsForFile)
+	diags := p.collectDiagnostics(ctx, sourceFile, true /*concurrent*/, p.getSemanticDiagnosticsForFile)
+	if sourceFile == nil {
+		diags = core.Concatenate(diags, p.getGlobalDiagnostics())
+	}
+	return SortAndDeduplicateDiagnostics(diags)
 }
 
 func (p *Program) GetSemanticDiagnosticsWithoutNoEmitFiltering(ctx context.Context, sourceFiles []*ast.SourceFile) map[*ast.SourceFile][]*ast.Diagnostic {
@@ -1026,7 +1030,7 @@ func emitModuleKindIsNonNodeESM(moduleKind core.ModuleKind) bool {
 	return moduleKind >= core.ModuleKindES2015 && moduleKind <= core.ModuleKindESNext
 }
 
-func (p *Program) GetGlobalDiagnostics(ctx context.Context) []*ast.Diagnostic {
+func (p *Program) getGlobalDiagnostics() []*ast.Diagnostic {
 	if len(p.files) == 0 {
 		return nil
 	}
@@ -1041,7 +1045,7 @@ func (p *Program) GetGlobalDiagnostics(ctx context.Context) []*ast.Diagnostic {
 		globalDiagnostics[idx] = checker.GetGlobalDiagnostics()
 	})
 
-	return SortAndDeduplicateDiagnostics(slices.Concat(globalDiagnostics...))
+	return slices.Concat(globalDiagnostics...)
 }
 
 func (p *Program) GetDeclarationDiagnostics(ctx context.Context, sourceFile *ast.SourceFile) []*ast.Diagnostic {
@@ -1438,7 +1442,6 @@ type ProgramLike interface {
 	GetSyntacticDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic
 	GetBindDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic
 	GetProgramDiagnostics() []*ast.Diagnostic
-	GetGlobalDiagnostics(ctx context.Context) []*ast.Diagnostic
 	GetSemanticDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic
 	GetDeclarationDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic
 	GetSuggestionDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic
@@ -1489,15 +1492,11 @@ func GetDiagnosticsOfAnyProgram(
 		getBindDiagnostics(ctx, file)
 
 		if program.Options().ListFilesOnly.IsFalseOrUnknown() {
-			allDiagnostics = append(allDiagnostics, program.GetGlobalDiagnostics(ctx)...)
-
 			if len(allDiagnostics) == configFileParsingDiagnosticsLength {
 				allDiagnostics = append(allDiagnostics, getSemanticDiagnostics(ctx, file)...)
-				// Ask for the global diagnostics again (they were empty above); we may have found new during checking, e.g. missing globals.
-				allDiagnostics = append(allDiagnostics, program.GetGlobalDiagnostics(ctx)...)
 			}
 
-			if (skipNoEmitCheckForDtsDiagnostics || program.Options().NoEmit.IsTrue()) && program.Options().GetEmitDeclarations() && len(allDiagnostics) == configFileParsingDiagnosticsLength {
+			if len(allDiagnostics) == configFileParsingDiagnosticsLength && (skipNoEmitCheckForDtsDiagnostics || program.Options().NoEmit.IsTrue()) && program.Options().GetEmitDeclarations() {
 				allDiagnostics = append(allDiagnostics, program.GetDeclarationDiagnostics(ctx, file)...)
 			}
 		}

internal/execute/incremental/program.go

@@ -137,11 +137,6 @@ func (p *Program) GetProgramDiagnostics() []*ast.Diagnostic {
 	return p.program.GetProgramDiagnostics()
 }
 
-func (p *Program) GetGlobalDiagnostics(ctx context.Context) []*ast.Diagnostic {
-	p.panicIfNoProgram("GetGlobalDiagnostics")
-	return p.program.GetGlobalDiagnostics(ctx)
-}
-
 // GetSemanticDiagnostics implements compiler.AnyProgram interface.
 func (p *Program) GetSemanticDiagnostics(ctx context.Context, file *ast.SourceFile) []*ast.Diagnostic {
 	p.panicIfNoProgram("GetSemanticDiagnostics")
@@ -358,8 +353,7 @@ func (p *Program) ensureHasErrorsForState(ctx context.Context, program *compiler
 	if hasIncludeProcessingDiagnostics() ||
 		len(program.GetConfigFileParsingDiagnostics()) > 0 ||
 		len(program.GetSyntacticDiagnostics(ctx, nil)) > 0 ||
-		len(program.GetProgramDiagnostics()) > 0 ||
-		len(program.GetGlobalDiagnostics(ctx)) > 0 {
+		len(program.GetProgramDiagnostics()) > 0 {
 		p.snapshot.hasErrors = core.TSTrue
 		// Dont need to encode semantic errors state since the syntax and program diagnostics are encoded as present
 		p.snapshot.hasSemanticErrors = false

internal/testutil/harnessutil/harnessutil.go

@@ -681,7 +681,6 @@ func compileFilesWithHost(
 	diagnostics = append(diagnostics, program.GetProgramDiagnostics()...)
 	diagnostics = append(diagnostics, program.GetSyntacticDiagnostics(ctx, nil)...)
 	diagnostics = append(diagnostics, program.GetSemanticDiagnostics(ctx, nil)...)
-	diagnostics = append(diagnostics, program.GetGlobalDiagnostics(ctx)...)
 	if config.CompilerOptions().GetEmitDeclarations() {
 		diagnostics = append(diagnostics, program.GetDeclarationDiagnostics(ctx, nil)...)
 	}