Fix inlay hints crash with property access expression (#2273)

Author: gabritto

internal/fourslash/tests/inlayHintsElementAccess_test.go

@@ -0,0 +1,30 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/ls/lsutil"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestInlayHintsElementAccess(t *testing.T) {
+	t.Parallel()
+
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `interface MySymbol {
+	readonly "my dispose": unique symbol
+}
+
+declare var mySymbol: MySymbol;
+
+let foo = {
+	[mySymbol["my dispose"]]: () => {}
+}
+`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyBaselineInlayHints(t, nil /*span*/, &lsutil.UserPreferences{InlayHints: lsutil.InlayHintsPreferences{
+		IncludeInlayVariableTypeHints: true,
+	}})
+}

internal/fourslash/tests/inlayHintsUsing_test.go

@@ -0,0 +1,24 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/ls/lsutil"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestInlayHintsUsing(t *testing.T) {
+	t.Parallel()
+
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `// @target: esnext
+using _defer = {
+	[Symbol.dispose]() {},
+};`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyBaselineInlayHints(t, nil /*span*/, &lsutil.UserPreferences{InlayHints: lsutil.InlayHintsPreferences{
+		IncludeInlayVariableTypeHints: true,
+	}})
+}

internal/ls/inlay_hints.go

@@ -720,6 +720,15 @@ func (s *inlayHintState) getInlayHintLabelParts(node *ast.Node) []*lsproto.Inlay
 			parts = append(parts, &lsproto.InlayHintLabelPart{Value: "["})
 			visitForDisplayParts(node.Expression())
 			parts = append(parts, &lsproto.InlayHintLabelPart{Value: "]"})
+		case ast.KindPropertyAccessExpression:
+			visitForDisplayParts(node.Expression())
+			parts = append(parts, &lsproto.InlayHintLabelPart{Value: "."})
+			visitForDisplayParts(node.Name())
+		case ast.KindElementAccessExpression:
+			visitForDisplayParts(node.Expression())
+			parts = append(parts, &lsproto.InlayHintLabelPart{Value: "["})
+			visitForDisplayParts(node.AsElementAccessExpression().ArgumentExpression)
+			parts = append(parts, &lsproto.InlayHintLabelPart{Value: "]"})
 		default:
 			debug.FailBadSyntaxKind(node)
 		}

testdata/baselines/reference/fourslash/inlayHints/inlayHintsElementAccess.baseline

@@ -0,0 +1,61 @@
+// === Inlay Hints ===
+let foo = {
+       ^
+{
+  "position": {
+    "line": 6,
+    "character": 7
+  },
+  "label": [
+    {
+      "value": ": "
+    },
+    {
+      "value": "{"
+    },
+    {
+      "value": " "
+    },
+    {
+      "value": "["
+    },
+    {
+      "value": "MySymbol"
+    },
+    {
+      "value": "["
+    },
+    {
+      "value": "\"my dispose\""
+    },
+    {
+      "value": "]"
+    },
+    {
+      "value": "]"
+    },
+    {
+      "value": ": "
+    },
+    {
+      "value": "("
+    },
+    {
+      "value": ")"
+    },
+    {
+      "value": " => "
+    },
+    {
+      "value": "void"
+    },
+    {
+      "value": " "
+    },
+    {
+      "value": "}"
+    }
+  ],
+  "kind": 1,
+  "paddingLeft": true
+}

testdata/baselines/reference/fourslash/inlayHints/inlayHintsUsing.baseline

@@ -0,0 +1,55 @@
+// === Inlay Hints ===
+using _defer = {
+            ^
+{
+  "position": {
+    "line": 0,
+    "character": 12
+  },
+  "label": [
+    {
+      "value": ": "
+    },
+    {
+      "value": "{"
+    },
+    {
+      "value": " "
+    },
+    {
+      "value": "["
+    },
+    {
+      "value": "Symbol"
+    },
+    {
+      "value": "."
+    },
+    {
+      "value": "dispose"
+    },
+    {
+      "value": "]"
+    },
+    {
+      "value": "("
+    },
+    {
+      "value": ")"
+    },
+    {
+      "value": ": "
+    },
+    {
+      "value": "void"
+    },
+    {
+      "value": " "
+    },
+    {
+      "value": "}"
+    }
+  ],
+  "kind": 1,
+  "paddingLeft": true
+}