Remove unused methods in ConGetSet and SCREEN_INFORMATION #9772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Feature
zadjii-msft
approved these changes
Apr 12, 2021
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
I love the fresh smell of dead code removal in the morning
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
GetConsoleCursorInfoandSetConsoleCursorInfomethods from the
ConGetSetinterface, and theGetScrollingRegionmethod from the
SCREEN_INFORMATIONclass. None of these methods areused anymore.
PR #2764 removed the last usage of
GetScrollingRegion.The
Get/SetConsoleCursorInfomethods don't seem to have ever been usedin the time that the terminal code has been open source, so whatever
purpose they originally served must have been replaced a long time ago.
The
GetScrollingRegionmethod was originally called from theScrollRegionfunction, but that usage was removed in PR #2764 when themargin handling was moved to a higher level.
I've checked that the code still compiles.
Closes #9771