Fix hot reload for icon, bell, close on exit; regressed in #16172 #19217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FPR tells me that this bug is present in... [✅] main |
PankajBhojwani
approved these changes
Aug 5, 2025
DHowett
added a commit
that referenced
this pull request
Aug 6, 2025
…9217) In #16172, we removed the propagation of the profile down into the Terminal Pane Content. It was holding on to the profile from the _old_ settings model (😱). This also broke background image hot reload. (cherry picked from commit 666a75b) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgdVVHA Service-Version: 1.23
DHowett
added a commit
that referenced
this pull request
Nov 24, 2025
…9217) In #16172, we removed the propagation of the profile down into the Terminal Pane Content. It was holding on to the profile from the _old_ settings model (😱). This also broke background image hot reload. (cherry picked from commit 666a75b) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgdVVHE Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16172, we removed the propagation of the profile down into the Terminal Pane Content.
It was holding on to the profile from the old settings model (😱).
This also broke background image hot reload.
Fixes 67ae9f6