#1363 - Campbell color scheme should change the foreground color from #F2F2F2 to #CCCCCC

[RyanBee-MSFT]

Changed the foreground color from #F2F2F2 to #CCCCCC.

Summary of the Pull Request

I changed where foreground is set in CascadiaSettings.cpp, from #F2F2F2 : RGB(242, 242, 242) to #CCCCCC : RGB(204, 204, 204).

References

PR Checklist

• Closes Campbell color scheme should change the foreground color from #F2F2F2 to #CCCCCC #1363
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed N/A
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Campbell color scheme should change the foreground color from #F2F2F2 to #CCCCCC #1363

Detailed Description of the Pull Request / Additional comments

As detailed in the bug, this slightly reduces the brightness of the default/foreground color of the Campbell color scheme from BrightWhite to White. This then allows the use of ESC sequence codes to add an intensity bit to make White display as BrightWhite. Without this change, using ESC[1m would keep the display color the same.

Validation Steps Performed

This was tested by manipulating the profiles.json to find the correct values to use. The code change was not tested outside this commit because it is a direct replacement of hard coded data, so there are no behavioral changes which should need to be evaluated separately.

[RyanBee-MSFT]

Just leaving this for you @DHowett-MSFT. This is the change as discussed in the bug. You had it set to tag Help-Wanted, so I just put it together. The work is there if you want to take it.

[DHowett-MSFT]

Thanks! If you’re up to it, you could do a whole color palette sweep and get solarized in there as well. What do you think? #1509

[miniksa]

I am good with subbing the one Campbell color per this PR at the time of review. If it expands to rev a whole bunch of other stuff, I'd love to re-review it then (or in a different PR).

[DHowett-MSFT]

(If you want to do additional color schemes, we can handle that in a separate PR. Thanks for doing this.)

[ghost]

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download