During session save, use the profile's GUID rather than its Name (#19113)

DHowett · DHowett · commit b6c7410a3317 · 2025-07-29T12:54:50.000-05:00
This will prevent Terminal from erroneously selecting a hidden (deleted, disabled or otherwise) profile of the same name during restoration and subsequently using the wrong settings. I am not certain why we used the name at all! Closes #19105 (cherry picked from commit c4fbb58) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgcbMe0 Service-Version: 1.23
diff --git a/src/cascadia/TerminalApp/TerminalPaneContent.cpp b/src/cascadia/TerminalApp/TerminalPaneContent.cpp
@@ -95,7 +95,7 @@ namespace winrt::TerminalApp::implementation
         NewTerminalArgs args{};
         const auto& controlSettings = _control.Settings();
 
-        args.Profile(controlSettings.ProfileName());
+        args.Profile(::Microsoft::Console::Utils::GuidToString(_profile.Guid()));
         // If we know the user's working directory use it instead of the profile.
         if (const auto dir = _control.WorkingDirectory(); !dir.empty())
         {

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ namespace winrt::TerminalApp::implementation`
`95`	`95`	`NewTerminalArgs args{};`
`96`	`96`	`const auto& controlSettings = _control.Settings();`
`97`	`97`
`98`		`- args.Profile(controlSettings.ProfileName());`
	`98`	`+ args.Profile(::Microsoft::Console::Utils::GuidToString(_profile.Guid()));`
`99`	`99`	`// If we know the user's working directory use it instead of the profile.`
`100`	`100`	`if (const auto dir = _control.WorkingDirectory(); !dir.empty())`
`101`	`101`	`{`