Skip to content

Commit 6c2f38c

Browse files
authored
Profiles Editor: make sure we notify the IconPath property (#19223)
There were instances where changing the icon or resetting it did not result in the text box changing. Regressed in #19143
1 parent 6fb70eb commit 6c2f38c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/cascadia/TerminalSettingsEditor/ProfileViewModel.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
108108
L"UsingImageIcon",
109109
L"LocalizedIcon",
110110
L"IconPreview",
111+
L"IconPath",
111112
L"EvaluatedIcon");
112113
}
113114
else if (viewModelProperty == L"CurrentBuiltInIcon")

src/cascadia/TerminalSettingsEditor/ProfileViewModel.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
9898
void IconPath(const winrt::hstring& path)
9999
{
100100
Icon(Model::MediaResourceHelper::FromString(path));
101-
_NotifyChanges(L"Icon");
101+
_NotifyChanges(L"Icon", L"IconPath");
102102
}
103103

104104
// starting directory

0 commit comments

Comments
 (0)