Stop returning null from CommandTestBase on exception (#950)

* Stop returning null for McpExceptions in CallToolAsync
* Fix lustre local live failues

Author: hallipr

core/Azure.Mcp.Core/tests/Azure.Mcp.Tests/Client/CommandTestsBase.cs

@@ -142,15 +142,6 @@ protected virtual async ValueTask InitializeAsyncInternal(TestProxyFixture? prox
         {
             // MCP client throws exceptions for error responses, but we want to handle them gracefully
             writeOutput($"MCP exception: {ex.Message}");
-
-            // For validation errors, we'll return a synthetic error response
-            if (ex.Message.Contains("An error occurred"))
-            {
-                // Return null to indicate error response (no results)
-                writeOutput("synthetic error response: null (error response)");
-                return null;
-            }
-
             throw; // Re-throw if we can't handle it
         }
 

eng/scripts/Deploy-TestResources.ps1

@@ -143,7 +143,7 @@ if ($jobInputs.Count -eq 1 -or !$Parallel) {
 } else {
     Write-Host "Deploying resources in parallel for $($jobInputs.Count) paths..." -ForegroundColor Yellow
     Write-Host "Cancelling this script (Ctrl-C) will not stop its background jobs. To stop the jobs, you must run:" -ForegroundColor Yellow
-    Write-Host "  Get-Job | Stop-Job -PassThrough | Remove-Job`n" -ForegroundColor Yellow
+    Write-Host "  Get-Job | Stop-Job -PassThru | Remove-Job`n" -ForegroundColor Yellow
 
     Start-Sleep -Seconds 2
 

tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs

@@ -115,18 +115,18 @@ public async Task Should_get_sku_info_no_zonal_support()
     public async Task Should_create_azure_managed_lustre_no_blob_no_cmk()
     {
         var fsName = $"amlfs-{Guid.NewGuid().ToString("N")[..8]}";
-        var subnetId = Environment.GetEnvironmentVariable("AMLFS_SUBNET_ID");
-        var location = Environment.GetEnvironmentVariable("LOCATION");
+        var subnetId = Settings.DeploymentOutputs["AMLFS_SUBNET_ID"];
+        var location = Settings.DeploymentOutputs["LOCATION"];
 
         // Calculate CMK required variables
 
-        var keyUri = Environment.GetEnvironmentVariable("KEY_URI_WITH_VERSION");
-        var keyVaultResourceId = Environment.GetEnvironmentVariable("KEY_VAULT_RESOURCE_ID");
-        var userAssignedIdentityId = Environment.GetEnvironmentVariable("USER_ASSIGNED_IDENTITY_RESOURCE_ID");
+        var keyUri = Settings.DeploymentOutputs["KEY_URI_WITH_VERSION"];
+        var keyVaultResourceId = Settings.DeploymentOutputs["KEY_VAULT_RESOURCE_ID"];
+        var userAssignedIdentityId = Settings.DeploymentOutputs["USER_ASSIGNED_IDENTITY_RESOURCE_ID"];
 
         // Calculate HSM required variables
-        var hsmDataContainerId = Environment.GetEnvironmentVariable("HSM_CONTAINER_ID");
-        var hsmLogContainerId = Environment.GetEnvironmentVariable("HSM_LOGS_CONTAINER_ID");
+        var hsmDataContainerId = Settings.DeploymentOutputs["HSM_CONTAINER_ID"];
+        var hsmLogContainerId = Settings.DeploymentOutputs["HSM_LOGS_CONTAINER_ID"];
 
         var result = await CallToolAsync(
             "managedlustre_fs_create",
@@ -232,8 +232,8 @@ public async Task Should_check_subnet_size_and_succeed()
                 { "subscription", Settings.SubscriptionId },
                 { "sku", "AMLFS-Durable-Premium-40" },
                 { "size", 480 },
-                { "location", Environment.GetEnvironmentVariable("LOCATION") },
-                { "subnet-id", Environment.GetEnvironmentVariable("AMLFS_SUBNET_ID") }
+                { "location", Settings.DeploymentOutputs["LOCATION"] },
+                { "subnet-id", Settings.DeploymentOutputs["AMLFS_SUBNET_ID"] }
             });
 
         var valid = result.AssertProperty("valid");
@@ -251,8 +251,8 @@ public async Task Should_check_subnet_size_and_fail()
                 { "subscription", Settings.SubscriptionId },
                 { "sku", "AMLFS-Durable-Premium-40" },
                 { "size", 1008 },
-                { "location", Environment.GetEnvironmentVariable("LOCATION") },
-                { "subnet-id", Environment.GetEnvironmentVariable("AMLFS_SUBNET_SMALL_ID") }
+                { "location", Settings.DeploymentOutputs["LOCATION"] },
+                { "subnet-id", Settings.DeploymentOutputs["AMLFS_SUBNET_SMALL_ID"] }
             });
 
         var valid = result.AssertProperty("valid");