Fix IE7 and IE8 compatibility #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingice
added a commit
that referenced
this pull request
Jan 9, 2013
Fix IE7 and IE8 compatibility
Owner
|
Looks great, thanks! |
Author
|
Thanks for merging so fast! |
michaelperrin
pushed a commit
to michaelperrin/ajax-chosen
that referenced
this pull request
Jul 24, 2013
…lity Fix IE7 and IE8 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 971a881 introduced a regression on Internet Explorer 7 & 8.
The Object.keys is not implemented on these browsers as described here: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/keys
I replaced this ECMAScript 5th Edition function by a more classic style. It's been tested on Internet Explorer.
Both Coffeescript & Javascript files have been modified, no need to compile.