-
-
Notifications
You must be signed in to change notification settings - Fork 458
Open
Labels
help wantedCommunity contributors can implement thisCommunity contributors can implement thisreadyReady for implementationReady for implementationtype: bugwork: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory
Milestone
Description
Here are two (very likely related) bugs:
-
A
- Begin with a unique column
- Edit cell, setting value to an existing value in the column.
- Observe error. Good.
- Refresh sheet via bottom right button. Notice error disappear. Good.
- Edit same cell again with same value.
- Expect to see the error as before.
- Instead, observe no error. Bad ❌
- Refresh via bottom button again. Expect the value to reset. Observe it to still display in the cell, even when selecting other cells. This is really bad! ❌
- Refreshing the whole page resets the value.
-
B
- Make or find a "Date" cell.
- Verify that the "Time Format" for the column is set to "Short time 24 hr"
- Double-click the cell to enter edit mode.
- Manually enter the text "7:00 PM" and press Enter.
- Observe that the cell saves and displays as "19:00". Good.
- Double-click to enter edit mode again.
- Observe that the cell still displays as "19:00". Good.
- Press Escape to exit edit mode.
- Expect the cell to still display as "19:00".
- Instead, observe that the cell now displays as "7:00 PM". Bad ❌
- Select another cell and observe that the original cell returns to displaying "19:00". Good. But weird!!
To any community contributors considering picking this up: I expect this issue to be tricky. A fix will most likely involve a fair bit of refactoring and require a good understanding of the specific ways in which Svelte handles state.
Metadata
Metadata
Assignees
Labels
help wantedCommunity contributors can implement thisCommunity contributors can implement thisreadyReady for implementationReady for implementationtype: bugwork: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory