-
-
Notifications
You must be signed in to change notification settings - Fork 93
Add support for custom information per benchmark run #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ubuntu hirsute has reached EOL, so I guess the CI failure is ok? Regardning AppVeyor, I have no experience with Windoes, so don't know how to address the error message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's a nice feature, I like it! Thanks for the contribution. I have some minor comments.
I think context name is ok, at least I don't have one that I think is better.
about const char* overloads, please add one, and the implementation can just call the std::string version then.
Given that there is a constructor Some more observations:
Is that something that should be addressed? |
197209b to
fd887b2
Compare
fd887b2 to
8aec596
Compare
|
I addressed all open issues. This is ready for review again. 🙂 |
|
Thanks a lot! |
* Fix some typos * Fix some more typos (#77 follow-up) * Add/Fix link to Bench::context
bench.context("name", "value"){{context(name)}}produce empty output (for that variable)throws an exceptionBench::run; my use case assumes that all variables are needed for all runsbench.clearContext()Unfortunately, I haven't been able to build and therefore check the docs I wrote.
Also, I saw that some methods are overloaded for
char const*andstd::string const&. ShouldBench::contextdo the same? What aboutResult::context?Do you think
contextis a feasible name? If not, how should these methods be called?