spike: get eslint v9 working #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This was just created to record my findings and does need to be merged in so I'm closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve been hacking away at tying to get the eslint v9 set up working In the widget codebase - specifically I was spiking out the new Eslint in the widget package listing again.
Main problem I was having was with
eslint-config-react-appand I can’t get that to work at all - not even when using with using some of the tooling eslint provides to help migrate legacy config.Some of the other config and plugin tools have been updated - for example
eslint-plugin-prettierhas documentation for the new “flat config” style for eslint and its easy to get those working.I couldn’t find anything about ‘‘eslint-config-react-app’ using the new eslint flat config - its not been published in a couple of years and we might have to seriously think about moving away from it. I started to take a look at the plugins and config it uses under the hood - some have already adopted support for flat config, such as
eslint-plugin-react, but others are still implementing support, for exampleeslint-plugin-react-hooksis maintained by the React team and they still have an open PR for supporting the new config style for eslint.