Skip to content

Conversation

@kshalot
Copy link
Contributor

@kshalot kshalot commented Nov 27, 2025

Cherry pick of #7899 on release-0.13.

#7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity

For details on the cherry pick process, see the cherry pick requests page.

TAS: Fix the `requiredDuringSchedulingIgnoredDuringExecution` node affinity setting being ignored in topology-aware scheduling.

@k8s-ci-robot k8s-ci-robot added this to the v0.13 milestone Nov 27, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 27, 2025
@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 879fcec
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/692826cc77493c0008ff9ed5

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kshalot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2025
@kshalot kshalot changed the title Automated cherry pick of #7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity [release-0.13]: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity Nov 27, 2025
@kshalot kshalot changed the title [release-0.13]: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity [release-0.13] TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity Nov 27, 2025
@kshalot kshalot changed the title [release-0.13] TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity Automated cherry pick of #7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/ok-to-test
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kshalot, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm cancel
changes to imports are required

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo November 27, 2025 09:59
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1bbccf18461677cbac48881caad2807e8cb9e761

@kshalot kshalot force-pushed the automated-cherry-pick-of-#7899-upstream-release-0.13 branch from 0e48770 to cdbbb3f Compare November 27, 2025 10:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf0900f78f0eb4f9700318cd8d4130cde58cf356

@kshalot
Copy link
Contributor Author

kshalot commented Nov 27, 2025

Looks like an unrelated flake

/test pull-kueue-test-e2e-tas-release-0-13

@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7936/pull-kueue-test-e2e-tas-release-0-13/1993989254161633280

Yes, I remember we fixed somehting like this on the main branch, maybe we didn't cherrypick, let me look it up

@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

I was thinking about this one #7326, but the fix was CPed: #7376, it is something different.

@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

Opened to track it: #7947

@k8s-ci-robot k8s-ci-robot merged commit a2187f5 into kubernetes-sigs:release-0.13 Nov 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants