Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Nov 17, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

v1beta2: change default for waitForPodsReady.blockAdmission to false

Which issue(s) this PR fixes:

Fixes #7656

Special notes for your reviewer:

Does this PR introduce a user-facing change?

v1beta2: change default for waitForPodsReady.blockAdmission to false

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 17, 2025
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 9267cc4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/691ad021c544ee00089a3e23

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2025
@mbobrovskyi mbobrovskyi changed the title v1beta2: change default for waitForPodsReady.blockAdmission to false WIP: v1beta2: change default for waitForPodsReady.blockAdmission to false Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025
@mbobrovskyi mbobrovskyi force-pushed the cleanup/change-default-for-waitForPodsReady.blockAdmission-to-false branch from f50e707 to 7031f41 Compare November 17, 2025 06:20
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2025
@mbobrovskyi mbobrovskyi changed the title WIP: v1beta2: change default for waitForPodsReady.blockAdmission to false v1beta2: change default for waitForPodsReady.blockAdmission to false Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 17, 2025
@mbobrovskyi mbobrovskyi force-pushed the cleanup/change-default-for-waitForPodsReady.blockAdmission-to-false branch from 7031f41 to fd9e062 Compare November 17, 2025 06:36
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2025
@mbobrovskyi mbobrovskyi force-pushed the cleanup/change-default-for-waitForPodsReady.blockAdmission-to-false branch from fd9e062 to d0a5a99 Compare November 17, 2025 06:54
@mbobrovskyi mbobrovskyi force-pushed the cleanup/change-default-for-waitForPodsReady.blockAdmission-to-false branch from d0a5a99 to 9267cc4 Compare November 17, 2025 07:34
@mimowo
Copy link
Contributor

mimowo commented Nov 17, 2025

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 17, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 17, 2025

Thank you 👍
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6847e9f6cab2785c21fa3f19740558c3e91250d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7443a1e into kubernetes-sigs:main Nov 17, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Nov 17, 2025
@mbobrovskyi mbobrovskyi deleted the cleanup/change-default-for-waitForPodsReady.blockAdmission-to-false branch November 17, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1beta2: change default for waitForPodsReady.blockAdmission to false

3 participants