Skip to content

KEP-2349: Move MultiKueue external custom Job support to Beta #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 17, 2025
Merged

KEP-2349: Move MultiKueue external custom Job support to Beta #7669

k8s-ci-robot merged 1 commit into from
Nov 17, 2025

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Nov 14, 2025 •
edited by k8s-ci-robot
Loading

Added MultiKueue external custom Job support to Beta. Modified integration to remove feature gate.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Graduate the support for running external jobs to Beta.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 14, 2025
@netlify
Copy link

netlify bot commented Nov 14, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1002a62
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/691ab4ac1e1de6000814f6f7

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

Hi @khrm. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2025
@khrm
Copy link
Contributor Author

khrm commented Nov 14, 2025

@mimowo @kannon92 Please review this for v0.15.

@khrm khrm mentioned this pull request Nov 14, 2025
Closed
36 tasks
@kannon92
Copy link
Contributor

kannon92 commented Nov 14, 2025

Please add a release note.

@kannon92
Copy link
Contributor

kannon92 commented Nov 14, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 14, 2025

Please add a release note.

yes, you need to add the release note in the format like
image

for the robot to pick up and remove the hold label

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

@kannon92: /release-note-edit must be used with a single release note block.

In response to this:

/release-note-edit

Move External Custom Job implementation for MultiKueue to Beta.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor

kannon92 commented Nov 14, 2025

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 14, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 14, 2025

yes, you need to add the release note in the format like

actually I changed that on my own

@khrm
KEP-2349: Move MultiKueue external custom Job support to Beta
1002a62 
Added MultiKueue external custom Job support to Beta. Modified
integration to remove feature gate.
@khrm khrm force-pushed the f/2349-move-to-beta branch from 261213e to 1002a62 Compare November 17, 2025 05:37
mimowo
mimowo reviewed Nov 17, 2025
View reviewed changes
keps/2349-multikueue-external-custom-job-support/README.md
- **Feature Gate:** `MultiKueueAdaptersForCustomJobs`
- Implementation is behind a feature gate.
- The generic adapter for custom jobs is implemented.
- *Completed*
Copy link
Contributor

@mimowo mimowo Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. remove

@mimowo
Copy link
Contributor

mimowo commented Nov 17, 2025

/lgtm
/approve
Merging to allow testing from main early. Please address #7669 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 17, 2025

LGTM label has been added.

Git tree hash: 48beaff8f2f25bd638a3b35e4265d1e4e4bd4546

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit b87b793 into kubernetes-sigs:main Nov 17, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Nov 17, 2025
khrm added a commit to khrm/kueue that referenced this pull request Nov 17, 2025
@khrm
Fixing the KEP/2349 README.md
5ae85f0 
We addressed comment at kubernetes-sigs#7669 (comment)
khrm added a commit to khrm/kueue that referenced this pull request Nov 17, 2025
@khrm
Fix inconsistency in the KEP/2349 README.md
1bc360d 
This PR addresses the review comment at:
kubernetes-sigs#7669 (comment)
@khrm khrm mentioned this pull request Nov 17, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Nov 17, 2025
@khrm
Fix inconsistency in the KEP/2349 README.md (#7698)
f342ff9 
This PR addresses the review comment at:
#7669 (comment)
Singularity23x0 pushed a commit to Singularity23x0/kueue that referenced this pull request Nov 17, 2025
@khrm @Singularity23x0
KEP-2349: Move MultiKueue external custom Job support to Beta (kubern…
b9f23bb 
…etes-sigs#7669)

Added MultiKueue external custom Job support to Beta. Modified
integration to remove feature gate.
Singularity23x0 pushed a commit to Singularity23x0/kueue that referenced this pull request Nov 17, 2025
@khrm @Singularity23x0
Fix inconsistency in the KEP/2349 README.md (kubernetes-sigs#7698)
ab2ef7e 
This PR addresses the review comment at:
kubernetes-sigs#7669 (comment)
@mimowo
Copy link
Contributor

mimowo commented Nov 28, 2025

/release-note-edit

MultiKueue: Graduate the support for running external job to Beta.

@mimowo
Copy link
Contributor

mimowo commented Nov 28, 2025

/release-note-edit

MultiKueue: Graduate the support for running external jobs to Beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@khrm @k8s-ci-robot @kannon92 @mimowo