v1beta2: graduate Config API #7375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
mbobrovskyi
force-pushed
the
feature/bump-config-version
branch
from
3d733a0 to
ee5bfc1
Compare
mbobrovskyi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
Contributor
|
Am I right that our e2e tests are still using v1beta1, proving that the conversion works? EDIT: if this is the case it is good actually, we can migrate tests in follow up PRs. Ideally we keep one sanity test using old API version. |
mimowo
reviewed
Oct 24, 2025
mbobrovskyi
force-pushed
the
feature/bump-config-version
branch
from
bfc4954 to
85e4be0
Compare
mimowo
reviewed
Oct 24, 2025
|
|
||
| // +kubebuilder:object:generate=true | ||
| // +groupName=config.kueue.x-k8s.io | ||
| // +k8s:conversion-gen=sigs.k8s.io/kueue/apis/config/v1beta2 |
Contributor
There was a problem hiding this comment.
I'm wondering if the generated conversion is needed in this case, since the types didn't change (so far).
Please check, maybe no need. If this is the case we could add when the configs diverage.
Contributor
Author
There was a problem hiding this comment.
I checked — we need this; otherwise, we’ll get an error.
k logs -f -l app.kubernetes.io/name=kueue -n kueue-system --tail=1000
2025-10-24T07:50:09.243725217Z ERROR setup kueue/main.go:133 Unable to load the configuration {"error": "converting (v1beta1.Configuration) to (v1beta2.Configuration): unknown conversion"}
main.main
/workspace/cmd/kueue/main.go:133
runtime.main
/usr/local/go/src/runtime/proc.go:285
2025-10-24T07:50:09.241558459Z ERROR setup kueue/main.go:133 Unable to load the configuration {"error": "converting (v1beta1.Configuration) to (v1beta2.Configuration): unknown conversion"}
main.main
/workspace/cmd/kueue/main.go:133
runtime.main
/usr/local/go/src/runtime/proc.go:285
Contributor
Contributor
|
/test pull-kueue-test-e2e-tas-main |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 9ed6f5204dd7d1b2bc6213b2d3ad665d2cc9e721
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Singularity23x0
pushed a commit
to Singularity23x0/kueue
that referenced
this pull request
Nov 3, 2025
* Copy v1beta1 to v1beta2. * v1beta2: graduate Config API * Add conversion logic. * Keep one test with v1beta1 version.
Contributor
|
/release-note-edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Graduate Config API to v1beta2
Which issue(s) this PR fixes:
Fixes #7373
Special notes for your reviewer:
Does this PR introduce a user-facing change?