Skip to content

Conversation

@bobsongplus
Copy link
Contributor

@bobsongplus bobsongplus commented Oct 20, 2025

What type of PR is this?

Add one of the following kinds:
/kind cleanup

Optionally add one or more of the following kinds if applicable:

/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # part of #7247

Special notes for your reviewer:

Does this PR introduce a user-facing change?

v1beta2: Remove deprecated QueueVisibility in configMap (it was already non-functional).

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c78950b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6900814bd76f41000838c338

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bobsongplus. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 20, 2025

/ok-to-test
/hold
I think we can only drop that in v1beta2. We are during migration, hopefully this on next week we will have v1beta2 for configuration.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2025
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bobsongplus / name: bob (c78950b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 20, 2025
@bobsongplus
Copy link
Contributor Author

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 24, 2025

We already have v1beta2, please update the PR and rebase.

@mimowo
Copy link
Contributor

mimowo commented Oct 24, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 27, 2025
@bobsongplus
Copy link
Contributor Author

Please also fix imports using make lint-fix.

Done

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2025
@mbobrovskyi
Copy link
Contributor

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58bd17764a71a08adf7dad20f2c01c993f9f0cd1

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Oct 28, 2025

Could you please fix release-note on the description of PR to fix do-not-merge/release-note-label-needed label.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2025
@mbobrovskyi
Copy link
Contributor

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo October 28, 2025 09:01
@bobsongplus
Copy link
Contributor Author

Could you please fix release-note on the description of PR to fix do-not-merge/release-note-label-needed label.

Release note added to PR description.

@mimowo
Copy link
Contributor

mimowo commented Oct 28, 2025

/approve
Awesome,, thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobsongplus, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2f15cbb into kubernetes-sigs:main Oct 28, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 28, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2025

Oh in this PR we forgot to remove the types related to the setting: https://github.com/kubernetes-sigs/kueue/pull/7283/files#diff-20464b5f6136625baf94aaf5ec415014c355020bac0a4d9441567a2d98a35767R318-R325

@bobsongplus would you like to follow up?

@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2025

in any case opened #7437 for grabbing

Singularity23x0 pushed a commit to Singularity23x0/kueue that referenced this pull request Nov 3, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 28, 2025

/release-note-edit

v1beta2: Remove deprecated QueueVisibility in configMap (it was already non-functional). 

/kind api-change
/remove-kind deprecation

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants