-
Notifications
You must be signed in to change notification settings - Fork 479
Deprecate QueueVisibility for v1beta2 #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
Hi @bobsongplus. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
|
|
/check-cla |
|
We already have v1beta2, please update the PR and rebase. |
|
/unhold |
Done |
Signed-off-by: song <[email protected]>
|
Thank you! |
|
LGTM label has been added. Git tree hash: 58bd17764a71a08adf7dad20f2c01c993f9f0cd1
|
|
Could you please fix release-note on the description of PR to fix |
|
/cc @mimowo |
Release note added to PR description. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobsongplus, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Oh in this PR we forgot to remove the types related to the setting: https://github.com/kubernetes-sigs/kueue/pull/7283/files#diff-20464b5f6136625baf94aaf5ec415014c355020bac0a4d9441567a2d98a35767R318-R325 @bobsongplus would you like to follow up? |
|
in any case opened #7437 for grabbing |
Signed-off-by: song <[email protected]>
|
/release-note-edit /kind api-change |
What type of PR is this?
Add one of the following kinds:
/kind cleanup
Optionally add one or more of the following kinds if applicable:
/kind deprecation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # part of #7247
Special notes for your reviewer:
Does this PR introduce a user-facing change?