Skip to content

Remove the deprecated queue annotation #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 3 commits into from
Oct 15, 2025
Merged

Remove the deprecated queue annotation #7271

k8s-ci-robot merged 3 commits into from
Oct 15, 2025
+22 −78

Conversation

@ganczak-commits
Copy link
Contributor

@ganczak-commits ganczak-commits commented Oct 15, 2025 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

This PR removes the deprecated queue annotation, as preliminary cleanup for v1beta2. Users are expected to use the queue label instead.

Which issue(s) this PR fixes:

Part of #7113

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed the deprecated workload annotation key "kueue.x-k8s.io/queue-name".

ACTION REQUIRED: Please ensure you are using the workload label "kueue.x-k8s.io/queue-name" instead.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 15, 2025
@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 16cc723
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68efa5f2640b340008a8842b
😎 Deploy Preview https://deploy-preview-7271--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2025

Hi @ganczak-commits. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 15, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2025
mbobrovskyi
mbobrovskyi reviewed Oct 15, 2025
View reviewed changes
mbobrovskyi
mbobrovskyi reviewed Oct 15, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 15, 2025
@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Oct 15, 2025

/release-note-edit

Removed the deprecated workload annotation key "kueue.x-k8s.io/queue-name".

ACTION REQUIRED: Please ensure you are using the workload label "kueue.x-k8s.io/queue-name" instead.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 15, 2025

Thanks 👍
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2025

LGTM label has been added.

Git tree hash: 0422ff25dfe7b1daf1e1a3199aec482ea97af7ff

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ganczak-commits, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6b1f938 into kubernetes-sigs:main Oct 15, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 15, 2025
@mimowo mimowo mentioned this pull request Oct 24, 2025
Closed
4 tasks
nerdeveloper added a commit to nerdeveloper/kueue that referenced this pull request Oct 27, 2025
@nerdeveloper
v1beta2: Drop APIs deprecated for long
7294468 
Remove long-deprecated APIs from v1beta2 as requested in kubernetes-sigs#7247:

- QueueVisibility API (deprecated since 0.9, implementation already dropped)
- retryDelayMinutes from AdmissionCheck API (deprecated since v0.8)
- PodIntegrationOptions (deprecated since 0.11, replaced by ManagedJobsNamespaceSelector)

Note: Queue-name annotation was already removed in kubernetes-sigs#7271

The APIs remain available in v1beta1 for backward compatibility.
Conversion functions handle the transition by ignoring deprecated fields
when converting from v1beta1 to v1beta2.

Fixes kubernetes-sigs#7247
@nerdeveloper nerdeveloper mentioned this pull request Oct 27, 2025
Closed
@rsevilla87 rsevilla87 mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

+1 more reviewer

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@ganczak-commits @k8s-ci-robot @mimowo @mbobrovskyi