-
Notifications
You must be signed in to change notification settings - Fork 479
TAS: Fix JobSet validation. #4130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAS: Fix JobSet validation. #4130
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @mimowo |
|
/lgtm |
|
LGTM label has been added. Git tree hash: c716ed31c15f8a74d8770b7fc55fea7a16ebf2c8
|
|
/release-note-edit |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.10 release-0.9 |
|
@mimowo: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mimowo: new pull request created: #4132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.9 |
|
@mbobrovskyi: new pull request created: #4155 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* TAS: Fix JobSet validation. * Fixes after cherry-pick.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixed a bug that doesn't allow to validate JobSet when both kueue.x-k8s.io/podset-required-topology and kueue.x-k8s.io/podset-preferred-topology annotations are set.
Which issue(s) this PR fixes:
Fixes #4122
Special notes for your reviewer:
Does this PR introduce a user-facing change?