Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Feb 3, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixed a bug that doesn't allow to validate JobSet when both kueue.x-k8s.io/podset-required-topology and kueue.x-k8s.io/podset-preferred-topology annotations are set.

Which issue(s) this PR fixes:

Fixes #4122

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TAS: Fixed a bug that allows to create a JobSet with both kueue.x-k8s.io/podset-required-topology and kueue.x-k8s.io/podset-preferred-topology annotations set on the PodTemplate.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2025
@netlify
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 4dd704e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67a0a19dc12f2900081cbf98
😎 Deploy Preview https://deploy-preview-4130--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo February 3, 2025 11:00
@mszadkow
Copy link
Contributor

mszadkow commented Feb 3, 2025

/lgtm
thanks for tests

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c716ed31c15f8a74d8770b7fc55fea7a16ebf2c8

@mimowo
Copy link
Contributor

mimowo commented Feb 3, 2025

/release-note-edit

TAS: Fixed a bug that allows to create a JobSet with both kueue.x-k8s.io/podset-required-topology and kueue.x-k8s.io/podset-preferred-topology annotations set on the PodTemplate.

@mimowo
Copy link
Contributor

mimowo commented Feb 3, 2025

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 3, 2025

/cherry-pick release-0.10 release-0.9
We can cherry-pick strengthened validation since this is an alpha feature still. Also, it can be easily mitigated by user by just not setting both annotations :)

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.10 release-0.9
We can cherry-pick strengthened validation since this is an alpha feature still. Also, it can be easily mitigated by user by just not setting both annotations :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 14e2ca7 into kubernetes-sigs:main Feb 3, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Feb 3, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #4132

In response to this:

/cherry-pick release-0.10 release-0.9
We can cherry-pick strengthened validation since this is an alpha feature still. Also, it can be easily mitigated by user by just not setting both annotations :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

FillZpp pushed a commit to leptonai/kueue that referenced this pull request Feb 5, 2025
@mbobrovskyi mbobrovskyi deleted the fix/jobset-tas-validation branch February 5, 2025 14:18
@mbobrovskyi
Copy link
Contributor Author

/cherry-pick release-0.9

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mbobrovskyi: new pull request created: #4155

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot pushed a commit that referenced this pull request Feb 5, 2025
* TAS: Fix JobSet validation.

* Fixes after cherry-pick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TAS: topology request validation doesn't work for JobSet

5 participants