Skip to content

Commit 48e59d7

Browse files
committed
Refactor admission check conversion functions and remove deprecated retryDelayMinutes field from documentation
1 parent 8831bf5 commit 48e59d7

File tree

3 files changed

+35
-20
lines changed

3 files changed

+35
-20
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/*
2+
Copyright The Kubernetes Authors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
package v1beta1
18+
19+
import (
20+
conversionapi "k8s.io/apimachinery/pkg/conversion"
21+
22+
"sigs.k8s.io/kueue/apis/kueue/v1beta2"
23+
)
24+
25+
//lint:file-ignore ST1003 "generated Convert_* calls below use underscores"
26+
//revive:disable:var-naming
27+
28+
func Convert_v1beta1_AdmissionCheckSpec_To_v1beta2_AdmissionCheckSpec(in *AdmissionCheckSpec, out *v1beta2.AdmissionCheckSpec, s conversionapi.Scope) error {
29+
return autoConvert_v1beta1_AdmissionCheckSpec_To_v1beta2_AdmissionCheckSpec(in, out, s)
30+
}

apis/kueue/v1beta1/zz_generated.conversion.go

Lines changed: 5 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

site/content/en/docs/reference/kueue.v1beta2.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -498,16 +498,6 @@ The description is limited to a maximum of 2048 characters.</p>
498498
not necessarily a Kubernetes Pod or Deployment name. Cannot be empty.</p>
499499
</td>
500500
</tr>
501-
<tr><td><code>retryDelayMinutes</code><br/>
502-
<code>int64</code>
503-
</td>
504-
<td>
505-
<p>retryDelayMinutes specifies how long to keep the workload suspended after
506-
a failed check (after it transitioned to False). When the delay period has passed, the check
507-
state goes to &quot;Unknown&quot;. The default is 15 min.
508-
Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.</p>
509-
</td>
510-
</tr>
511501
<tr><td><code>parameters</code><br/>
512502
<a href="#kueue-x-k8s-io-v1beta2-AdmissionCheckParametersReference"><code>AdmissionCheckParametersReference</code></a>
513503
</td>

0 commit comments

Comments
 (0)