Skip to content

Commit 403ae60

Browse files
author
song
committed
Fix deprecated comment for QueueVisibility
Signed-off-by: song <[email protected]>
1 parent ef20e3a commit 403ae60

File tree

4 files changed

+1
-215
lines changed

4 files changed

+1
-215
lines changed

‎apis/config/v1beta1/configuration_types.go‎

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ type Configuration struct {
8282
// integrations (including K8S job).
8383
Integrations *Integrations `json:"integrations,omitempty"`
8484

85-
// QueueVisibility is configuration to expose the information about the top
86-
// pending workloads.
87-
// Deprecated: This field will be removed on v1beta2, use VisibilityOnDemand
88-
// (https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/)
89-
// instead.
90-
QueueVisibility *QueueVisibility `json:"queueVisibility,omitempty"`
91-
9285
// MultiKueue controls the behaviour of the MultiKueue AdmissionCheck Controller.
9386
MultiKueue *MultiKueue `json:"multiKueue,omitempty"`
9487

@@ -437,27 +430,6 @@ type PodIntegrationOptions struct {
437430
PodSelector *metav1.LabelSelector `json:"podSelector,omitempty"`
438431
}
439432

440-
type QueueVisibility struct {
441-
// ClusterQueues is configuration to expose the information
442-
// about the top pending workloads in the cluster queue.
443-
ClusterQueues *ClusterQueueVisibility `json:"clusterQueues,omitempty"`
444-
445-
// UpdateIntervalSeconds specifies the time interval for updates to the structure
446-
// of the top pending workloads in the queues.
447-
// The minimum value is 1.
448-
// Defaults to 5.
449-
UpdateIntervalSeconds int32 `json:"updateIntervalSeconds,omitempty"`
450-
}
451-
452-
type ClusterQueueVisibility struct {
453-
// MaxCount indicates the maximal number of pending workloads exposed in the
454-
// cluster queue status. When the value is set to 0, then ClusterQueue
455-
// visibility updates are disabled.
456-
// The maximal value is 4000.
457-
// Defaults to 10.
458-
MaxCount int32 `json:"maxCount,omitempty"`
459-
}
460-
461433
type Resources struct {
462434
// ExcludedResourcePrefixes defines which resources should be ignored by Kueue
463435
ExcludeResourcePrefixes []string `json:"excludeResourcePrefixes,omitempty"`

‎apis/config/v1beta1/zz_generated.deepcopy.go‎

Lines changed: 0 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎site/content/en/docs/reference/kueue-config.v1beta1.md‎

Lines changed: 0 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -88,34 +88,6 @@ connection.</p>
8888
</tbody>
8989
</table>
9090

91-
## `ClusterQueueVisibility` {#ClusterQueueVisibility}
92-
93-
94-
**Appears in:**
95-
96-
- [QueueVisibility](#QueueVisibility)
97-
98-
99-
100-
<table class="table">
101-
<thead><tr><th width="30%">Field</th><th>Description</th></tr></thead>
102-
<tbody>
103-
104-
105-
<tr><td><code>maxCount</code> <B>[Required]</B><br/>
106-
<code>int32</code>
107-
</td>
108-
<td>
109-
<p>MaxCount indicates the maximal number of pending workloads exposed in the
110-
cluster queue status. When the value is set to 0, then ClusterQueue
111-
visibility updates are disabled.
112-
The maximal value is 4000.
113-
Defaults to 10.</p>
114-
</td>
115-
</tr>
116-
</tbody>
117-
</table>
118-
11991
## `Configuration` {#Configuration}
12092

12193

@@ -209,17 +181,6 @@ API server client.</p>
209181
integrations (including K8S job).</p>
210182
</td>
211183
</tr>
212-
<tr><td><code>queueVisibility</code> <B>[Required]</B><br/>
213-
<a href="#QueueVisibility"><code>QueueVisibility</code></a>
214-
</td>
215-
<td>
216-
<p>QueueVisibility is configuration to expose the information about the top
217-
pending workloads.
218-
Deprecated: This field will be removed on v1beta2, use VisibilityOnDemand
219-
(https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/)
220-
instead.</p>
221-
</td>
222-
</tr>
223184
<tr><td><code>multiKueue</code> <B>[Required]</B><br/>
224185
<a href="#MultiKueue"><code>MultiKueue</code></a>
225186
</td>
@@ -877,40 +838,6 @@ A nil value disables automatic deletion of Workloads.</p>
877838

878839

879840

880-
## `QueueVisibility` {#QueueVisibility}
881-
882-
883-
**Appears in:**
884-
885-
886-
887-
888-
<table class="table">
889-
<thead><tr><th width="30%">Field</th><th>Description</th></tr></thead>
890-
<tbody>
891-
892-
893-
<tr><td><code>clusterQueues</code> <B>[Required]</B><br/>
894-
<a href="#ClusterQueueVisibility"><code>ClusterQueueVisibility</code></a>
895-
</td>
896-
<td>
897-
<p>ClusterQueues is configuration to expose the information
898-
about the top pending workloads in the cluster queue.</p>
899-
</td>
900-
</tr>
901-
<tr><td><code>updateIntervalSeconds</code> <B>[Required]</B><br/>
902-
<code>int32</code>
903-
</td>
904-
<td>
905-
<p>UpdateIntervalSeconds specifies the time interval for updates to the structure
906-
of the top pending workloads in the queues.
907-
The minimum value is 1.
908-
Defaults to 5.</p>
909-
</td>
910-
</tr>
911-
</tbody>
912-
</table>
913-
914841
## `RequeuingStrategy` {#RequeuingStrategy}
915842

916843

‎site/content/zh-CN/docs/reference/kueue-config.v1beta1.md‎

Lines changed: 1 addition & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -87,34 +87,6 @@ connection.</p>
8787
</tbody>
8888
</table>
8989

90-
## `ClusterQueueVisibility` {#ClusterQueueVisibility}
91-
92-
93-
**Appears in:**
94-
95-
- [QueueVisibility](#QueueVisibility)
96-
97-
98-
99-
<table class="table">
100-
<thead><tr><th width="30%">Field</th><th>Description</th></tr></thead>
101-
<tbody>
102-
103-
104-
<tr><td><code>maxCount</code> <B>[Required]</B><br/>
105-
<code>int32</code>
106-
</td>
107-
<td>
108-
<p>MaxCount indicates the maximal number of pending workloads exposed in the
109-
cluster queue status. When the value is set to 0, then ClusterQueue
110-
visibility updates are disabled.
111-
The maximal value is 4000.
112-
Defaults to 10.</p>
113-
</td>
114-
</tr>
115-
</tbody>
116-
</table>
117-
11890
## `Configuration` {#Configuration}
11991

12092

@@ -208,17 +180,6 @@ API server client.</p>
208180
integrations (including K8S job).</p>
209181
</td>
210182
</tr>
211-
<tr><td><code>queueVisibility</code> <B>[Required]</B><br/>
212-
<a href="#QueueVisibility"><code>QueueVisibility</code></a>
213-
</td>
214-
<td>
215-
<p>QueueVisibility is configuration to expose the information about the top
216-
pending workloads.
217-
Deprecated: This field will be removed on v1beta2, use VisibilityOnDemand
218-
(https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/)
219-
instead.</p>
220-
</td>
221-
</tr>
222183
<tr><td><code>multiKueue</code> <B>[Required]</B><br/>
223184
<a href="#MultiKueue"><code>MultiKueue</code></a>
224185
</td>
@@ -780,40 +741,6 @@ A nil value disables automatic deletion of Workloads.</p>
780741

781742

782743

783-
## `QueueVisibility` {#QueueVisibility}
784-
785-
786-
**Appears in:**
787-
788-
789-
790-
791-
<table class="table">
792-
<thead><tr><th width="30%">Field</th><th>Description</th></tr></thead>
793-
<tbody>
794-
795-
796-
<tr><td><code>clusterQueues</code> <B>[Required]</B><br/>
797-
<a href="#ClusterQueueVisibility"><code>ClusterQueueVisibility</code></a>
798-
</td>
799-
<td>
800-
<p>ClusterQueues is configuration to expose the information
801-
about the top pending workloads in the cluster queue.</p>
802-
</td>
803-
</tr>
804-
<tr><td><code>updateIntervalSeconds</code> <B>[Required]</B><br/>
805-
<code>int32</code>
806-
</td>
807-
<td>
808-
<p>UpdateIntervalSeconds specifies the time interval for updates to the structure
809-
of the top pending workloads in the queues.
810-
The minimum value is 1.
811-
Defaults to 5.</p>
812-
</td>
813-
</tr>
814-
</tbody>
815-
</table>
816-
817744
## `RequeuingStrategy` {#RequeuingStrategy}
818745

819746

@@ -1083,4 +1010,4 @@ Represented using metav1.Duration (e.g. &quot;10m&quot;, &quot;1h30m&quot;).</p>
10831010
</td>
10841011
</tr>
10851012
</tbody>
1086-
</table>
1013+
</table>

0 commit comments

Comments
 (0)