Automated cherry pick of #7299: Update PriorityClass only for WorkloadPriorityClassSource. (#7306)

* Update PriorityClass only for WorkloadPriorityClassSource.

* Fix after cherry-pick.

Author: mbobrovskyi

pkg/controller/jobframework/reconciler.go

@@ -596,8 +596,8 @@ func (r *JobReconciler) ReconcileGenericJob(ctx context.Context, req ctrl.Reques
 			}
 			return ctrl.Result{}, err
 		}
-		// update workload priority if job's label changed
-		if WorkloadPriorityClassName(object) != wl.Spec.PriorityClassName {
+		// Update workload priority if job's label changed.
+		if wl.Spec.PriorityClassSource == constants.WorkloadPriorityClassSource && WorkloadPriorityClassName(object) != wl.Spec.PriorityClassName {
 			log.V(2).Info("Job changed priority, updating workload", "oldPriority", wl.Spec.PriorityClassName, "newPriority", WorkloadPriorityClassName(object))
 			if _, err = r.updateWorkloadToMatchJob(ctx, job, object, wl); err != nil {
 				log.Error(err, "Updating workload priority")

pkg/controller/jobs/job/job_controller_test.go

@@ -2714,6 +2714,48 @@ func TestReconciler(t *testing.T) {
 				},
 			},
 		},
+		"shouldn't update workload when priority class no changes": {
+			job: *baseJobWrapper.
+				Clone().
+				Suspend(true).
+				PriorityClass(basePCWrapper.Name).
+				UID("test-uid").
+				Obj(),
+			wantJob: *baseJobWrapper.
+				Clone().
+				PriorityClass(basePCWrapper.Name).
+				UID("test-uid").
+				Obj(),
+			priorityClasses: []client.Object{
+				basePCWrapper.Obj(), baseWPCWrapper.Obj(),
+			},
+			workloads: []kueue.Workload{
+				*utiltesting.MakeWorkload("job", "ns").
+					Finalizers(kueue.ResourceInUseFinalizerName).
+					PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).PriorityClass(basePCWrapper.Name).Request(corev1.ResourceCPU, "1").Obj()).
+					Queue("foo").
+					Priority(basePCWrapper.Value).
+					PriorityClassSource(constants.PodPriorityClassSource).
+					PriorityClass(basePCWrapper.Name).
+					Labels(map[string]string{
+						controllerconsts.JobUIDLabel: "test-uid",
+					}).
+					Obj(),
+			},
+			wantWorkloads: []kueue.Workload{
+				*utiltesting.MakeWorkload("job", "ns").
+					Finalizers(kueue.ResourceInUseFinalizerName).
+					PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).PriorityClass(basePCWrapper.Name).Request(corev1.ResourceCPU, "1").Obj()).
+					Queue("foo").
+					Priority(basePCWrapper.Value).
+					PriorityClassSource(constants.PodPriorityClassSource).
+					PriorityClass(basePCWrapper.Name).
+					Labels(map[string]string{
+						controllerconsts.JobUIDLabel: "test-uid",
+					}).
+					Obj(),
+			},
+		},
 		"the workload without uid label is created when job's uid is longer than 63 characters": {
 			job: *baseJobWrapper.
 				Clone().