Skip to content

Commit 16c3058

Browse files
bobsongplussong
authored andcommitted
Deprecate QueueVisibility for v1beta2
Signed-off-by: song <[email protected]>
1 parent b559e70 commit 16c3058

File tree

5 files changed

+980
-137
lines changed

5 files changed

+980
-137
lines changed

apis/config/v1beta1/zz_generated.conversion.go

Lines changed: 1 addition & 69 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/config/v1beta2/configuration_types.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ type Configuration struct {
8282
// integrations (including K8S job).
8383
Integrations *Integrations `json:"integrations,omitempty"`
8484

85-
// QueueVisibility is configuration to expose the information about the top
86-
// pending workloads.
87-
// Deprecated: This field will be removed on v1beta2, use VisibilityOnDemand
88-
// (https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/)
89-
// instead.
90-
QueueVisibility *QueueVisibility `json:"queueVisibility,omitempty"`
91-
9285
// MultiKueue controls the behaviour of the MultiKueue AdmissionCheck Controller.
9386
MultiKueue *MultiKueue `json:"multiKueue,omitempty"`
9487

@@ -437,27 +430,6 @@ type PodIntegrationOptions struct {
437430
PodSelector *metav1.LabelSelector `json:"podSelector,omitempty"`
438431
}
439432

440-
type QueueVisibility struct {
441-
// ClusterQueues is configuration to expose the information
442-
// about the top pending workloads in the cluster queue.
443-
ClusterQueues *ClusterQueueVisibility `json:"clusterQueues,omitempty"`
444-
445-
// UpdateIntervalSeconds specifies the time interval for updates to the structure
446-
// of the top pending workloads in the queues.
447-
// The minimum value is 1.
448-
// Defaults to 5.
449-
UpdateIntervalSeconds int32 `json:"updateIntervalSeconds,omitempty"`
450-
}
451-
452-
type ClusterQueueVisibility struct {
453-
// MaxCount indicates the maximal number of pending workloads exposed in the
454-
// cluster queue status. When the value is set to 0, then ClusterQueue
455-
// visibility updates are disabled.
456-
// The maximal value is 4000.
457-
// Defaults to 10.
458-
MaxCount int32 `json:"maxCount,omitempty"`
459-
}
460-
461433
type Resources struct {
462434
// ExcludedResourcePrefixes defines which resources should be ignored by Kueue
463435
ExcludeResourcePrefixes []string `json:"excludeResourcePrefixes,omitempty"`

apis/config/v1beta2/zz_generated.deepcopy.go

Lines changed: 0 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hack/genref/config.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ apis:
1313
package: sigs.k8s.io/kueue
1414
path: apis/config/v1beta1
1515

16+
- name: kueue-config
17+
title: Kueue Configuration API
18+
package: sigs.k8s.io/kueue
19+
path: apis/config/v1beta2
20+
1621
- name: kueue-alpha
1722
title: Kueue Alpha API
1823
package: sigs.k8s.io/kueue

0 commit comments

Comments
 (0)