-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Import centos bootstrap os task for Alma/Rocky Linux #12264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @root-expert! |
|
Hi @root-expert. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
tmurakam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add almalinux.yml too.
81b5790 to
411e63c
Compare
|
@tmurakam Thanks for the suggestions, I incorporated them. |
|
/lgtm |
|
Thanks @root-expert |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: root-expert, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Oops... I wrote the same code as the PR code in the issue and didn't think to PR it. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Rocky tasks are missing from the
bootstrap_osrole causing issues with kubespray installation when the cluster is behind a proxy.Which issue(s) this PR fixes:
Fixes #11528
Does this PR introduce a user-facing change?: